Re: [PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-05-11 Thread David Sterba
On Thu, Apr 09, 2015 at 02:34:54PM -0700, Omar Sandoval wrote: > There's nothing to stop a user from passing both subvol= and subvolid= > to mount, but if they don't refer to the same subvolume, someone is > going to be surprised at some point. Error out on this case, but allow > users to pass in

Re: [PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-05-11 Thread David Sterba
On Thu, Apr 09, 2015 at 02:34:54PM -0700, Omar Sandoval wrote: There's nothing to stop a user from passing both subvol= and subvolid= to mount, but if they don't refer to the same subvolume, someone is going to be surprised at some point. Error out on this case, but allow users to pass in both

Re: [PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-04-14 Thread David Sterba
On Fri, Apr 10, 2015 at 08:39:53AM +0800, Qu Wenruo wrote: > > There's nothing to stop a user from passing both subvol= and subvolid= > > to mount, but if they don't refer to the same subvolume, someone is > > going to be surprised at some point. Error out on this case, but allow > > users to pass

Re: [PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-04-14 Thread David Sterba
On Fri, Apr 10, 2015 at 08:39:53AM +0800, Qu Wenruo wrote: There's nothing to stop a user from passing both subvol= and subvolid= to mount, but if they don't refer to the same subvolume, someone is going to be surprised at some point. Error out on this case, but allow users to pass in both

[PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-04-09 Thread Omar Sandoval
There's nothing to stop a user from passing both subvol= and subvolid= to mount, but if they don't refer to the same subvolume, someone is going to be surprised at some point. Error out on this case, but allow users to pass in both if they do match (which they could, for example, get out of

[PATCH v2 4/6] Btrfs: fail on mismatched subvol and subvolid mount options

2015-04-09 Thread Omar Sandoval
There's nothing to stop a user from passing both subvol= and subvolid= to mount, but if they don't refer to the same subvolume, someone is going to be surprised at some point. Error out on this case, but allow users to pass in both if they do match (which they could, for example, get out of