Re: [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-28 Thread Bjorn Helgaas
On Wed, Feb 28, 2018 at 05:45:37PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Not sure if those two worked by design or just by chance so far. In any > > case, it's at least

Re: [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-28 Thread Bjorn Helgaas
On Wed, Feb 28, 2018 at 05:45:37PM +0200, Andy Shevchenko wrote: > On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka wrote: > > From: Jan Kiszka > > > > Not sure if those two worked by design or just by chance so far. In any > > case, it's at least cleaner and clearer to express this in a single > >

Re: [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-28 Thread Andy Shevchenko
On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Not sure if those two worked by design or just by chance so far. In any > case, it's at least cleaner and clearer to express this in a single > config statement. I would add

Re: [PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-28 Thread Andy Shevchenko
On Wed, Feb 28, 2018 at 8:34 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Not sure if those two worked by design or just by chance so far. In any > case, it's at least cleaner and clearer to express this in a single > config statement. I would add a reference to the commit which brought that in

[PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-27 Thread Jan Kiszka
From: Jan Kiszka Not sure if those two worked by design or just by chance so far. In any case, it's at least cleaner and clearer to express this in a single config statement. Signed-off-by: Jan Kiszka --- arch/x86/Kconfig | 9 +++-- 1 file

[PATCH v2 4/6] x86: Consolidate PCI_MMCONFIG configs

2018-02-27 Thread Jan Kiszka
From: Jan Kiszka Not sure if those two worked by design or just by chance so far. In any case, it's at least cleaner and clearer to express this in a single config statement. Signed-off-by: Jan Kiszka --- arch/x86/Kconfig | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff