Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Stephen Boyd
Quoting Stefan Wahren (2019-06-07 02:13:54) > Hi Viresh, > > Am 07.06.19 um 05:09 schrieb Viresh Kumar: > > On 06-06-19, 11:23, Stephen Boyd wrote: > >> Yes, thanks. I see that largely follows the commit description so it > >> looks OK to me. > > Do you want to provide your Reviewed/Acked-by tag

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Nicolas Saenz Julienne
On Fri, 2019-06-07 at 13:42 +0200, Stefan Wahren wrote: > Hi Nicolas, > > Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > > Raspberry Pi's firmware offers and interface though which update it's > > performance requirements. It allows us to request for specific runtime > > frequencies,

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Stefan Wahren
Hi Nicolas, Am 06.06.19 um 16:22 schrieb Nicolas Saenz Julienne: > Raspberry Pi's firmware offers and interface though which update it's > performance requirements. It allows us to request for specific runtime > frequencies, which the firmware might or might not respect, depending on > the

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-07 Thread Stefan Wahren
Hi Viresh, Am 07.06.19 um 05:09 schrieb Viresh Kumar: > On 06-06-19, 11:23, Stephen Boyd wrote: >> Yes, thanks. I see that largely follows the commit description so it >> looks OK to me. > Do you want to provide your Reviewed/Acked-by tag before I apply it ? Nicolas wanted to send a V3 of this

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Viresh Kumar
On 06-06-19, 11:23, Stephen Boyd wrote: > Yes, thanks. I see that largely follows the commit description so it > looks OK to me. Do you want to provide your Reviewed/Acked-by tag before I apply it ? -- viresh

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Nicolas Saenz Julienne
On Thu, 2019-06-06 at 11:23 -0700, Stephen Boyd wrote: > Quoting Nicolas Saenz Julienne (2019-06-06 11:10:04) > > On Thu, 2019-06-06 at 10:36 -0700, Stephen Boyd wrote: > > > Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16) > > > > Hi Stephen, > > > > Thanks for the review. > > > > > > > > On

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2019-06-06 11:10:04) > On Thu, 2019-06-06 at 10:36 -0700, Stephen Boyd wrote: > > Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16) > > > Hi Stephen, > > > Thanks for the review. > > > > > > On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote: > > > > Quoting

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Nicolas Saenz Julienne
On Thu, 2019-06-06 at 10:36 -0700, Stephen Boyd wrote: > Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16) > > Hi Stephen, > > Thanks for the review. > > > > On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote: > > > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56) > > > > diff --git

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2019-06-06 10:22:16) > Hi Stephen, > Thanks for the review. > > On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote: > > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56) > > > diff --git a/drivers/cpufreq/raspberrypi-cpufreq.c > > >

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Nicolas Saenz Julienne
Hi Stephen, Thanks for the review. On Thu, 2019-06-06 at 10:09 -0700, Stephen Boyd wrote: > Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56) > > diff --git a/drivers/cpufreq/raspberrypi-cpufreq.c > > b/drivers/cpufreq/raspberrypi-cpufreq.c > > new file mode 100644 > > index

Re: [PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Stephen Boyd
Quoting Nicolas Saenz Julienne (2019-06-06 07:22:56) > diff --git a/drivers/cpufreq/raspberrypi-cpufreq.c > b/drivers/cpufreq/raspberrypi-cpufreq.c > new file mode 100644 > index ..99b59d5a50aa > --- /dev/null > +++ b/drivers/cpufreq/raspberrypi-cpufreq.c [...] > + > +/* > + * Since

[PATCH v2 4/7] cpufreq: add driver for Raspbery Pi

2019-06-06 Thread Nicolas Saenz Julienne
Raspberry Pi's firmware offers and interface though which update it's performance requirements. It allows us to request for specific runtime frequencies, which the firmware might or might not respect, depending on the firmware configuration and thermals. As the maximum and minimum frequencies are