Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-08-05 Thread Ionela Voinescu
On Tuesday 04 Aug 2020 at 12:16:56 (+0530), Viresh Kumar wrote: > On 03-08-20, 16:24, Ionela Voinescu wrote: > > Right, cpufreq_register_driver() should check that at least one of them > > is present > > > (although currently cpufreq_register_driver() will return > > -EINVAL if .fast_switch()

Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-08-04 Thread Viresh Kumar
On 03-08-20, 16:24, Ionela Voinescu wrote: > Right, cpufreq_register_driver() should check that at least one of them > is present > (although currently cpufreq_register_driver() will return > -EINVAL if .fast_switch() alone is present - something to be fixed). I think it is fine as there is no

Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-08-03 Thread Ionela Voinescu
Hi Viresh, On Thursday 30 Jul 2020 at 10:13:46 (+0530), Viresh Kumar wrote: > On 22-07-20, 10:37, Ionela Voinescu wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > index 3497c1cd6818..1d0b046fe8e9 100644 > > --- a/drivers/cpufreq/cpufreq.c > > +++

Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-07-29 Thread Viresh Kumar
On 22-07-20, 10:37, Ionela Voinescu wrote: > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 3497c1cd6818..1d0b046fe8e9 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -61,6 +61,9 @@ static struct cpufreq_driver *cpufreq_driver; > static

Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-07-29 Thread Ionela Voinescu
Hi, On Monday 27 Jul 2020 at 16:02:18 (+0200), Rafael J. Wysocki wrote: > On Wed, Jul 22, 2020 at 11:38 AM Ionela Voinescu > wrote: [..] > > +static inline > > +void enable_cpufreq_freq_invariance(struct cpufreq_driver *driver) > > +{ > > + if ((driver->target || driver->target_index ||

Re: [PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-07-27 Thread Rafael J. Wysocki
On Wed, Jul 22, 2020 at 11:38 AM Ionela Voinescu wrote: > > Now that the update of the FI scale factor is done in cpufreq core for > selected functions - target(), target_index() and fast_switch(), > we can provide feedback to the task scheduler and architecture code > on whether cpufreq supports

[PATCH v2 4/7] cpufreq: report whether cpufreq supports Frequency Invariance (FI)

2020-07-22 Thread Ionela Voinescu
Now that the update of the FI scale factor is done in cpufreq core for selected functions - target(), target_index() and fast_switch(), we can provide feedback to the task scheduler and architecture code on whether cpufreq supports FI. For this purpose, provide error and debug messages, together