Re: [PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Tom Zanussi
Hi Steve, On Mon, 2020-10-12 at 18:04 -0400, Steven Rostedt wrote: > On Mon, 12 Oct 2020 15:18:06 -0500 > Tom Zanussi wrote: > > > +static int cmdstr_append(char *buf, const char *str, int > > *remaining) > > +{ > > + int len = strlen(str); > > + > > + if (len + 1 >= *remaining) { > > +

Re: [PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 15:18:06 -0500 Tom Zanussi wrote: > +static int cmdstr_append(char *buf, const char *str, int *remaining) > +{ > + int len = strlen(str); > + > + if (len + 1 >= *remaining) { > + synth_err(SYNTH_ERR_CMD_TOO_LONG, 0); > + return -EINVAL; > +

Re: [PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Tom Zanussi
Hi Steve, On Mon, 2020-10-12 at 17:49 -0400, Steven Rostedt wrote: > On Mon, 12 Oct 2020 17:42:40 -0400 > Steven Rostedt wrote: > > > On Mon, 12 Oct 2020 15:18:06 -0500 > > Tom Zanussi wrote: > > > > > +static char last_cmd[MAX_FILTER_STR_VAL]; > > > + > > > +static int errpos(const char *str)

Re: [PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 17:42:40 -0400 Steven Rostedt wrote: > On Mon, 12 Oct 2020 15:18:06 -0500 > Tom Zanussi wrote: > > > +static char last_cmd[MAX_FILTER_STR_VAL]; > > + > > +static int errpos(const char *str) > > +{ > > + return err_pos(last_cmd, str); > > +} > > + > > +static void last_cmd_

Re: [PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Steven Rostedt
On Mon, 12 Oct 2020 15:18:06 -0500 Tom Zanussi wrote: > +static char last_cmd[MAX_FILTER_STR_VAL]; > + > +static int errpos(const char *str) > +{ > + return err_pos(last_cmd, str); > +} > + > +static void last_cmd_set(char *str) > +{ > + if (!str) > + return; > + > + strnc

[PATCH v2 4/7] tracing: Add synthetic event error logging

2020-10-12 Thread Tom Zanussi
Add support for synthetic event error logging, which entails adding a logging function for it, a way to save the synthetic event command, and a set of specific synthetic event parse error strings and handling. Signed-off-by: Tom Zanussi --- kernel/trace/trace_events_synth.c | 114 +++