Re: [PATCH v2 4/8] MIPS: Remove "weak" from get_c0_perfcount_int() declaration

2015-07-14 Thread Andrew Bresticker
Hi Bjorn, On Tue, Jul 14, 2015 at 9:46 AM, Bjorn Helgaas wrote: > Weak header file declarations are error-prone because they make every > definition weak, and the linker chooses one based on link order (see > 10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node > decl")). > >

[PATCH v2 4/8] MIPS: Remove "weak" from get_c0_perfcount_int() declaration

2015-07-14 Thread Bjorn Helgaas
Weak header file declarations are error-prone because they make every definition weak, and the linker chooses one based on link order (see 10629d711ed7 ("PCI: Remove __weak annotation from pcibios_get_phb_of_node decl")). get_c0_perfcount_int() is defined in several files. Every definition is wea