Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-08-11 Thread Eric Dumazet
On 8/11/20 3:37 AM, Jason Xing wrote: > Hi everyone, > > Could anyone take a look at this issue? I believe it is of high-importance. > Though Eric gave the proper patch a few months ago, the stable branch > still hasn't applied or merged this fix. It seems this patch was > forgotten :( Sure,

Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-08-11 Thread Jason Xing
Hi everyone, Could anyone take a look at this issue? I believe it is of high-importance. Though Eric gave the proper patch a few months ago, the stable branch still hasn't applied or merged this fix. It seems this patch was forgotten :( Thanks, Jason On Thu, Jun 4, 2020 at 9:47 PM Jason Xing

Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread Jason Xing
On Thu, Jun 4, 2020 at 9:10 PM Eric Dumazet wrote: > > On Thu, Jun 4, 2020 at 2:01 AM wrote: > > > > From: Jason Xing > > > > When using BBR mode, too many tcp socks cannot be released because of > > duplicate use of the sock_hold() in the manner of tcp_internal_pacing() > > when RTO happens.

Re: [PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread Eric Dumazet
On Thu, Jun 4, 2020 at 2:01 AM wrote: > > From: Jason Xing > > When using BBR mode, too many tcp socks cannot be released because of > duplicate use of the sock_hold() in the manner of tcp_internal_pacing() > when RTO happens. Therefore, this situation maddly increases the slab > memory and then

[PATCH v2 4.19] tcp: fix TCP socks unreleased in BBR mode

2020-06-04 Thread kerneljasonxing
From: Jason Xing When using BBR mode, too many tcp socks cannot be released because of duplicate use of the sock_hold() in the manner of tcp_internal_pacing() when RTO happens. Therefore, this situation maddly increases the slab memory and then constantly triggers the OOM until crash. Besides,