Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Andy Shevchenko
On Fri, Feb 12, 2021 at 6:11 PM Rafael J. Wysocki wrote: > On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko > wrote: > > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > > > wrote: ... > > > > + if (ret) > > > > +

Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Rafael J. Wysocki
On Fri, Feb 12, 2021 at 5:01 PM Andy Shevchenko wrote: > > On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > > wrote: > > > > Refactor acpi_data_prop_read_single() for less LOCs and better > > > maintenance. > > Thanks for re

Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Andy Shevchenko
On Fri, Feb 12, 2021 at 03:31:24PM +0100, Rafael J. Wysocki wrote: > On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko > wrote: > > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance. Thanks for review, my answers below. ... > > + if (ret) > > + return

Re: [PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Rafael J. Wysocki
On Fri, Feb 12, 2021 at 3:14 PM Andy Shevchenko wrote: > > Refactor acpi_data_prop_read_single() for less LOCs and better maintenance. > > Signed-off-by: Andy Shevchenko > --- > drivers/acpi/property.c | 80 ++--- > 1 file changed, 34 insertions(+), 46 deleti

[PATCH v2 5/5] ACPI: property: Refactor acpi_data_prop_read_single()

2021-02-12 Thread Andy Shevchenko
Refactor acpi_data_prop_read_single() for less LOCs and better maintenance. Signed-off-by: Andy Shevchenko --- drivers/acpi/property.c | 80 ++--- 1 file changed, 34 insertions(+), 46 deletions(-) diff --git a/drivers/acpi/property.c b/drivers/acpi/property.c