Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-29 Thread Bjorn Helgaas
On Mon, Apr 28, 2014 at 8:02 PM, Suravee Suthikulanit wrote: > Sorry for late reply. My concern is that removing the "quirk_amd_nb_node()" > will affect the value of "numa_node" of the host bridge devices (i.e. > X:00.[18|19|1a|1b|1c|1d|1e|1f].X). I am not sure if any code is using this >

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-29 Thread Bjorn Helgaas
On Mon, Apr 28, 2014 at 8:02 PM, Suravee Suthikulanit suravee.suthikulpa...@amd.com wrote: Sorry for late reply. My concern is that removing the quirk_amd_nb_node() will affect the value of numa_node of the host bridge devices (i.e. X:00.[18|19|1a|1b|1c|1d|1e|1f].X). I am not sure if any

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-28 Thread Suravee Suthikulanit
On 4/21/2014 11:53 AM, Daniel J Blueman wrote: Hi Myron, On 04/20/2014 09:44 PM, Myron Stowe wrote: On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h,

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-28 Thread Myron Stowe
On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov wrote: > On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: >> With the amd_bus.c updates to support additional AMD processors (11h, 12h, >> 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch >> removes it. >> >>

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-28 Thread Myron Stowe
On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov b...@suse.de wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch removes it.

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-28 Thread Suravee Suthikulanit
On 4/21/2014 11:53 AM, Daniel J Blueman wrote: Hi Myron, On 04/20/2014 09:44 PM, Myron Stowe wrote: On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov b...@suse.de wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-21 Thread Daniel J Blueman
Hi Myron, On 04/20/2014 09:44 PM, Myron Stowe wrote: On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-21 Thread Daniel J Blueman
Hi Myron, On 04/20/2014 09:44 PM, Myron Stowe wrote: On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov b...@suse.de wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h)

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-20 Thread Myron Stowe
On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov wrote: > On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: >> With the amd_bus.c updates to support additional AMD processors (11h, 12h, >> 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch >> removes it. >> >>

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-20 Thread Borislav Petkov
On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: > With the amd_bus.c updates to support additional AMD processors (11h, 12h, > 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch > removes it. > > Signed-off-by: Myron Stowe Good idea. Has this been tested,

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-20 Thread Borislav Petkov
On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch removes it. Signed-off-by: Myron Stowe myron.st...@redhat.com Good idea. Has this

Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-20 Thread Myron Stowe
On Sun, Apr 20, 2014 at 4:54 AM, Borislav Petkov b...@suse.de wrote: On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote: With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch removes it.

[PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-18 Thread Myron Stowe
With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch removes it. Signed-off-by: Myron Stowe --- arch/x86/kernel/quirks.c | 58 -- 1 files changed, 0

[PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

2014-04-18 Thread Myron Stowe
With the amd_bus.c updates to support additional AMD processors (11h, 12h, 14h 15h and 16h) 'quirk_amd_nb_node' seems to be redundant. This patch removes it. Signed-off-by: Myron Stowe myron.st...@redhat.com --- arch/x86/kernel/quirks.c | 58 -- 1