Re: [PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'

2021-03-15 Thread Joe Perches
On Mon, 2021-03-15 at 11:24 +, tudor.amba...@microchip.com wrote: > On 3/15/21 8:53 AM, Joe Perches wrote: > > On Mon, 2021-03-08 at 11:58 +0530, Pratyush Yadav wrote: > > > On 06/03/21 11:50AM, Tudor Ambarus wrote: > > > > else is not generally useful after a break or return. > > > > > > > >

Re: [PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'

2021-03-15 Thread Tudor.Ambarus
On 3/15/21 8:53 AM, Joe Perches wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 2021-03-08 at 11:58 +0530, Pratyush Yadav wrote: >> On 06/03/21 11:50AM, Tudor Ambarus wrote: >>> else is not generally useful after a break or return.

Re: [PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'

2021-03-14 Thread Joe Perches
On Mon, 2021-03-08 at 11:58 +0530, Pratyush Yadav wrote: > On 06/03/21 11:50AM, Tudor Ambarus wrote: > > else is not generally useful after a break or return. > > > > Signed-off-by: Tudor Ambarus > > Reviewed-by: Pratyush Yadav > I don't think this improves the code. Generally, checkpatch is

Re: [PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'

2021-03-07 Thread Pratyush Yadav
On 06/03/21 11:50AM, Tudor Ambarus wrote: > else is not generally useful after a break or return. > > Signed-off-by: Tudor Ambarus Reviewed-by: Pratyush Yadav -- Regards, Pratyush Yadav Texas Instruments Inc.

[PATCH v2 5/5] mtd: spi-nor: swp: Drop 'else' after 'return'

2021-03-06 Thread Tudor Ambarus
else is not generally useful after a break or return. Signed-off-by: Tudor Ambarus --- drivers/mtd/spi-nor/swp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/mtd/spi-nor/swp.c b/drivers/mtd/spi-nor/swp.c index 75b9bb53d584..c35cb3becb41 100644 --- a/