Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-11-05 Thread Andreas Dilger
On Oct 20, 2018, at 11:46 AM, Trond Myklebust wrote: > > On Fri, 2018-10-19 at 22:48 +0200, Miklos Szeredi wrote: >> On Fri, Oct 19, 2018 at 8:14 PM, Trond Myklebust >> wrote: >>> On Fri, 2018-10-19 at 19:46 +0200, Miklos Szeredi wrote: How is it then that only STATX_ATIME is cleared and no

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-20 Thread Trond Myklebust
On Fri, 2018-10-19 at 22:48 +0200, Miklos Szeredi wrote: > On Fri, Oct 19, 2018 at 8:14 PM, Trond Myklebust > wrote: > > On Fri, 2018-10-19 at 19:46 +0200, Miklos Szeredi wrote: > > > How is it then that only STATX_ATIME is cleared and not the other > > > fields? > > > > It isn't just the atime.

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Miklos Szeredi
On Fri, Oct 19, 2018 at 8:14 PM, Trond Myklebust wrote: > On Fri, 2018-10-19 at 19:46 +0200, Miklos Szeredi wrote: >> How is it then that only STATX_ATIME is cleared and not the other >> fields? > > It isn't just the atime. We can also fail to revalidate the ctime and > mtime if they are not bein

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Trond Myklebust
On Fri, 2018-10-19 at 19:46 +0200, Miklos Szeredi wrote: > On Fri, Oct 19, 2018 at 5:52 PM, Trond Myklebust > wrote: > > On Fri, 2018-10-19 at 14:20 +0200, Miklos Szeredi wrote: > > > As per statx(2) man page only clear out flags that are > > > unsupported by > > > the > > > fs or have an unrepres

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Miklos Szeredi
On Fri, Oct 19, 2018 at 5:52 PM, Trond Myklebust wrote: > On Fri, 2018-10-19 at 14:20 +0200, Miklos Szeredi wrote: >> As per statx(2) man page only clear out flags that are unsupported by >> the >> fs or have an unrepresentable value. Atime is supported by NFS as >> long as >> it's supported on t

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Trond Myklebust
On Fri, 2018-10-19 at 14:20 +0200, Miklos Szeredi wrote: > As per statx(2) man page only clear out flags that are unsupported by > the > fs or have an unrepresentable value. Atime is supported by NFS as > long as > it's supported on the server. > > So the STATX_ATIME flag should not be cleared in

Re: [PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread David Howells
Miklos Szeredi wrote: > As per statx(2) man page only clear out flags that are unsupported by the > fs or have an unrepresentable value. Atime is supported by NFS as long as > it's supported on the server. > > So the STATX_ATIME flag should not be cleared in the result_mask if the > operation w

[PATCH v2 5/5] nfs: don't clear STATX_ATIME from result_mask

2018-10-19 Thread Miklos Szeredi
As per statx(2) man page only clear out flags that are unsupported by the fs or have an unrepresentable value. Atime is supported by NFS as long as it's supported on the server. So the STATX_ATIME flag should not be cleared in the result_mask if the operation was requested on a MNT_NOATIME or MNT