Re: [PATCH v2 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver

Hi, [...] > > + /* Wait for wait_idle */ > > + ret = readl_poll_timeout(phy_cr_para_ack, val, val, 10, 5000); > > + if (ret) > > + dev_err(dev, "Wait for wait_ilde state failed!\n"); > > It would be "wait_idle" rather than "wait_idle". [...] Apologies, meant to say "wait_ilde"

Re: [PATCH v2 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver

Hi, [...] > +static void fu740_phyregwrite(const uint8_t phy, const uint16_t addr, > + const uint16_t wrdata, struct fu740_pcie *afp) > +{ > + struct device *dev = afp->pci.dev; > + void __iomem *phy_cr_para_addr; > + void __iomem *phy_cr_para_wr_data; > +

[PATCH v2 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver

From: Paul Walmsley Add driver for the SiFive FU740 PCIe host controller. This controller is based on the DesignWare PCIe core. Signed-off-by: Paul Walmsley Co-developed-by: Henry Styles Signed-off-by: Henry Styles Co-developed-by: Erik Danie Signed-off-by: Erik Danie Co-developed-by: