Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On Tue, Apr 13, 2021 at 2:21 AM Chris Packham wrote: > On 13/04/21 10:52 am, Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > > wrote: > >> Use device managed functions an clean up error handling. > > For the god sake how have you tested this? > > The patch is broken. >

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On 13/04/21 11:21 am, Chris Packham wrote: > > On 13/04/21 10:52 am, Andy Shevchenko wrote: >> On Mon, Mar 29, 2021 at 4:54 AM Chris Packham >> wrote: >>> Use device managed functions an clean up error handling. >> For the god sake how have you tested this? >> The patch is broken. > I've clearly

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On 13/04/21 10:52 am, Andy Shevchenko wrote: > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > wrote: >> Use device managed functions an clean up error handling. > For the god sake how have you tested this? > The patch is broken. I've clearly missed the remove path in my testing. I was focused on

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On Tue, Apr 13, 2021 at 1:52 AM Andy Shevchenko wrote: > > On Mon, Mar 29, 2021 at 4:54 AM Chris Packham > wrote: > > > > Use device managed functions an clean up error handling. > > For the god sake how have you tested this? > The patch is broken. Looking into i2c-next and taking into account w

Re: [PATCH v2 5/6] i2c: mpc: use device managed APIs

On Mon, Mar 29, 2021 at 4:54 AM Chris Packham wrote: > > Use device managed functions an clean up error handling. For the god sake how have you tested this? The patch is broken. -- With Best Regards, Andy Shevchenko

[PATCH v2 5/6] i2c: mpc: use device managed APIs

Use device managed functions an clean up error handling. Signed-off-by: Chris Packham --- drivers/i2c/busses/i2c-mpc.c | 46 ++-- 1 file changed, 18 insertions(+), 28 deletions(-) diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c index 5b74