Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi David, On Sat, Apr 17, 2021 at 6:24 AM David Gow wrote: > > Like patch 1/6, I can apply it in MPTCP tree and send it later to > > net-next with other patches. > > Except if you guys prefer to apply it in KUnit tree and send it to > > linux-next? > > Given 1/6 is going to net-next, it makes sen

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi David, Nico, On 17/04/2021 06:24, David Gow wrote: Hi Matt, Like patch 1/6, I can apply it in MPTCP tree and send it later to net-next with other patches. Except if you guys prefer to apply it in KUnit tree and send it to linux-next? Given 1/6 is going to net-next, it makes sense to send

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi Matt, > Like patch 1/6, I can apply it in MPTCP tree and send it later to > net-next with other patches. > Except if you guys prefer to apply it in KUnit tree and send it to > linux-next? Given 1/6 is going to net-next, it makes sense to send this out that way too, then, IMHO. The only slight

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi David, Thank you for your very clear reply! On 15/04/2021 08:01, David Gow wrote: On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts wrote: Up to the KUnit maintainers to decide ;-) To summarise my view: personally, I'd prefer things the way this patch works: have everything end in _KUNIT_T

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi Nico, Matthieu, Thanks for going to the trouble of making these conform to the KUnit style guidelines. On Wed, Apr 14, 2021 at 5:25 PM Matthieu Baerts wrote: > > Hi Nico, > > On 14/04/2021 10:58, Nico Pache wrote: > > Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the > >

Re: [PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Hi Nico, On 14/04/2021 10:58, Nico Pache wrote: Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. For MPTCP, we have multiple KUnit tests: crypto and token. That's why we wrote TESTS with a S. I'm fine without S if we need to stick

[PATCH v2 5/6] kunit: mptcp: adhear to KUNIT formatting standard

Drop 'S' from end of CONFIG_MPTCP_KUNIT_TESTS inorder to adhear to the KUNIT *_KUNIT_TEST config name format. Fixes: a00a582203db (mptcp: move crypto test to KUNIT) Signed-off-by: Nico Pache --- net/mptcp/Kconfig | 2 +- net/mptcp/Makefile | 2 +- net/mptcp/crypto.c | 2 +- net/mptcp/token.c |