Re: [PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:29:04PM +0300, Sergey Suloev wrote: > Two helper functions were added in order to set/unset > specified flags in registers. Again, the diffstat is pretty neutral, so what is the benefit? Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and

Re: [PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers

2018-04-04 Thread Maxime Ripard
On Tue, Apr 03, 2018 at 06:29:04PM +0300, Sergey Suloev wrote: > Two helper functions were added in order to set/unset > specified flags in registers. Again, the diffstat is pretty neutral, so what is the benefit? Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and

[PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers

2018-04-03 Thread Sergey Suloev
Two helper functions were added in order to set/unset specified flags in registers. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun4i.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git

[PATCH v2 5/6] spi: sun4i: introduce register set/unset helpers

2018-04-03 Thread Sergey Suloev
Two helper functions were added in order to set/unset specified flags in registers. Signed-off-by: Sergey Suloev --- drivers/spi/spi-sun4i.c | 40 +++- 1 file changed, 19 insertions(+), 21 deletions(-) diff --git a/drivers/spi/spi-sun4i.c