Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

* Brian Gerst wrote: > On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov wrote: > > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: > >> The idea was to put the uncommon case (kernel thread) out of line for > >> performance reasons. > > > > A

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

* Brian Gerst wrote: > On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov wrote: > > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: > >> The idea was to put the uncommon case (kernel thread) out of line for > >> performance reasons. > > > > A comment saying so wouldn't hurt... >

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov wrote: > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: >> The idea was to put the uncommon case (kernel thread) out of line for >> performance reasons. > > A comment saying so wouldn't hurt... This is a fairly

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 11:14 AM, Borislav Petkov wrote: > On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: >> The idea was to put the uncommon case (kernel thread) out of line for >> performance reasons. > > A comment saying so wouldn't hurt... This is a fairly common pattern. Do

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: > The idea was to put the uncommon case (kernel thread) out of line for > performance reasons. A comment saying so wouldn't hurt... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 11:01:02AM -0400, Brian Gerst wrote: > The idea was to put the uncommon case (kernel thread) out of line for > performance reasons. A comment saying so wouldn't hurt... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 9:51 AM, Borislav Petkov wrote: > On Sat, Jun 18, 2016 at 04:56:17PM -0400, Brian Gerst wrote: >> Instead of setting up a fake pt_regs context, put the kernel thread >> function pointer and arg into the unused callee-restored registers >> of struct

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Mon, Jun 20, 2016 at 9:51 AM, Borislav Petkov wrote: > On Sat, Jun 18, 2016 at 04:56:17PM -0400, Brian Gerst wrote: >> Instead of setting up a fake pt_regs context, put the kernel thread >> function pointer and arg into the unused callee-restored registers >> of struct fork_frame. >> >>

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sat, Jun 18, 2016 at 04:56:17PM -0400, Brian Gerst wrote: > Instead of setting up a fake pt_regs context, put the kernel thread > function pointer and arg into the unused callee-restored registers > of struct fork_frame. > > Signed-off-by: Brian Gerst > --- >

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sat, Jun 18, 2016 at 04:56:17PM -0400, Brian Gerst wrote: > Instead of setting up a fake pt_regs context, put the kernel thread > function pointer and arg into the unused callee-restored registers > of struct fork_frame. > > Signed-off-by: Brian Gerst > --- > arch/x86/entry/entry_32.S|

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sun, Jun 19, 2016 at 5:28 PM, Andy Lutomirski wrote: > On Sat, Jun 18, 2016 at 1:56 PM, Brian Gerst wrote: >> Instead of setting up a fake pt_regs context, put the kernel thread >> function pointer and arg into the unused callee-restored registers >> of

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sun, Jun 19, 2016 at 5:28 PM, Andy Lutomirski wrote: > On Sat, Jun 18, 2016 at 1:56 PM, Brian Gerst wrote: >> Instead of setting up a fake pt_regs context, put the kernel thread >> function pointer and arg into the unused callee-restored registers >> of struct fork_frame. > > This seems

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sat, Jun 18, 2016 at 1:56 PM, Brian Gerst wrote: > Instead of setting up a fake pt_regs context, put the kernel thread > function pointer and arg into the unused callee-restored registers > of struct fork_frame. This seems generally okay. > > Signed-off-by: Brian Gerst

Re: [PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

On Sat, Jun 18, 2016 at 1:56 PM, Brian Gerst wrote: > Instead of setting up a fake pt_regs context, put the kernel thread > function pointer and arg into the unused callee-restored registers > of struct fork_frame. This seems generally okay. > > Signed-off-by: Brian Gerst > @@ -146,19 +147,12

[PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

Instead of setting up a fake pt_regs context, put the kernel thread function pointer and arg into the unused callee-restored registers of struct fork_frame. Signed-off-by: Brian Gerst --- arch/x86/entry/entry_32.S| 31 +++

[PATCH v2 5/6] x86: Pass kernel thread parameters in fork_frame

Instead of setting up a fake pt_regs context, put the kernel thread function pointer and arg into the unused callee-restored registers of struct fork_frame. Signed-off-by: Brian Gerst --- arch/x86/entry/entry_32.S| 31 +++ arch/x86/entry/entry_64.S| 35