Re: [PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-25 Thread Sebastian Andrzej Siewior
On 2020-05-25 09:18:19 [+0200], Ingo Molnar wrote: > > +static DEFINE_PER_CPU(struct local_evt, local_evt) = { > > + .counts = 0, > > I don't think zero initializations need to be written out explicitly. yes. > > + .lock = INIT_LOCAL_LOCK(lock), > > +}; > > > > static inline void send_msg(

Re: [PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-25 Thread Ingo Molnar
* Sebastian Andrzej Siewior wrote: > From: Mike Galbraith > > send_msg() disables preemption to avoid out-of-order messages. As the > code inside the preempt disabled section acquires regular spinlocks, > which are converted to 'sleeping' spinlocks on a PREEMPT_RT kernel and > eventually call

[PATCH v2 5/7] connector/cn_proc: Protect send_msg() with a local lock

2020-05-24 Thread Sebastian Andrzej Siewior
From: Mike Galbraith send_msg() disables preemption to avoid out-of-order messages. As the code inside the preempt disabled section acquires regular spinlocks, which are converted to 'sleeping' spinlocks on a PREEMPT_RT kernel and eventually calls into a memory allocator, this conflicts with the