Re: [PATCH v2 5/8] x86/kaslr: Simplify __process_mem_region

2020-07-28 Thread Arvind Sankar
On Tue, Jul 28, 2020 at 12:25:16PM -0700, Kees Cook wrote: > On Mon, Jul 27, 2020 at 07:07:58PM -0400, Arvind Sankar wrote: > > Get rid of unnecessary temporary variables and redundant tests in > > __process_mem_region. > > > > Fix one minor bug: in case of an overlap, the beginning of the region

Re: [PATCH v2 5/8] x86/kaslr: Simplify __process_mem_region

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:07:58PM -0400, Arvind Sankar wrote: > Get rid of unnecessary temporary variables and redundant tests in > __process_mem_region. > > Fix one minor bug: in case of an overlap, the beginning of the region > should be used even if it is exactly image_size, not just strictly

[PATCH v2 5/8] x86/kaslr: Simplify __process_mem_region

2020-07-27 Thread Arvind Sankar
Get rid of unnecessary temporary variables and redundant tests in __process_mem_region. Fix one minor bug: in case of an overlap, the beginning of the region should be used even if it is exactly image_size, not just strictly larger. Change type of minimum/image_size arguments in