Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-11-18 Thread Boris Brezillon
On Thu, 15 Nov 2018 15:26:48 +0100 Johan Hovold wrote: > On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote: > > On Tue, 23 Oct 2018 13:28:09 -0500 > > Rob Herring wrote: > > > > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote: > > > > > > > > On Mon, Aug 27, 2018 at 10:4

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-11-15 Thread Johan Hovold
On Tue, Oct 23, 2018 at 08:51:17PM +0200, Boris Brezillon wrote: > On Tue, 23 Oct 2018 13:28:09 -0500 > Rob Herring wrote: > > > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote: > > > > > > On Mon, Aug 27, 2018 at 10:48:42AM +0200, Boris Brezillon wrote: > > > > On Mon, 27 Aug 2018 10:44:14

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 13:28:09 -0500 Rob Herring wrote: > On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote: > > > > On Mon, Aug 27, 2018 at 10:48:42AM +0200, Boris Brezillon wrote: > > > On Mon, 27 Aug 2018 10:44:14 +0200 > > > Johan Hovold wrote: > > > > > > > On Mon, Aug 27, 2018 at 10:28

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-10-23 Thread Rob Herring
On Mon, Aug 27, 2018 at 4:44 AM Johan Hovold wrote: > > On Mon, Aug 27, 2018 at 10:48:42AM +0200, Boris Brezillon wrote: > > On Mon, 27 Aug 2018 10:44:14 +0200 > > Johan Hovold wrote: > > > > > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > > > Hi Johan > > > > > > > > On Mo

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
On Mon, Aug 27, 2018 at 10:48:42AM +0200, Boris Brezillon wrote: > On Mon, 27 Aug 2018 10:44:14 +0200 > Johan Hovold wrote: > > > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > > Hi Johan > > > > > > On Mon, 27 Aug 2018 10:21:49 +0200 > > > Johan Hovold wrote: > > > > >

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
On Mon, 27 Aug 2018 10:44:14 +0200 Johan Hovold wrote: > On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > > Hi Johan > > > > On Mon, 27 Aug 2018 10:21:49 +0200 > > Johan Hovold wrote: > > > > > Use the new of_get_compatible_child() helper to lookup the nfc child > > > node

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
On Mon, Aug 27, 2018 at 10:28:20AM +0200, Boris Brezillon wrote: > Hi Johan > > On Mon, 27 Aug 2018 10:21:49 +0200 > Johan Hovold wrote: > > > Use the new of_get_compatible_child() helper to lookup the nfc child > > node instead of using of_find_compatible_node(), which searches the > > entire t

Re: [PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Boris Brezillon
Hi Johan On Mon, 27 Aug 2018 10:21:49 +0200 Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the nfc child > node instead of using of_find_compatible_node(), which searches the > entire tree from a given start node and thus can return an unrelated > (i.e. non-child) n

[PATCH v2 5/9] mtd: nand: atmel: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the nfc child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe defe