Re: [PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint()

2014-01-20 Thread Alexander Gordeev
On Fri, Jan 17, 2014 at 03:01:10PM -0700, Keith Busch wrote: > >dev->entry[0].vector is initialized in nvme_dev_map(), and it's used > >for free_irq() above the area of your patch, so I don't think this is > >actually a bug, though it might be somewhat confusing. > > It is confusing, but there's a

Re: [PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint()

2014-01-17 Thread Keith Busch
On Fri, 17 Jan 2014, Bjorn Helgaas wrote: On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev wrote: In case MSI-X and MSI initialization failed the function irq_set_affinity_hint() is called with uninitialized value in dev->entry[0].vector. This update fixes the issue. dev->entry[0].vector i

Re: [PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint()

2014-01-17 Thread Bjorn Helgaas
On Fri, Jan 17, 2014 at 9:02 AM, Alexander Gordeev wrote: > In case MSI-X and MSI initialization failed the function > irq_set_affinity_hint() is called with uninitialized value > in dev->entry[0].vector. This update fixes the issue. dev->entry[0].vector is initialized in nvme_dev_map(), and it's

[PATCH v2 5/9] nvme: Fix invalid call to irq_set_affinity_hint()

2014-01-17 Thread Alexander Gordeev
In case MSI-X and MSI initialization failed the function irq_set_affinity_hint() is called with uninitialized value in dev->entry[0].vector. This update fixes the issue. Signed-off-by: Alexander Gordeev --- drivers/block/nvme-core.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deleti