Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread Dan Carpenter
On Fri, Dec 05, 2014 at 03:23:15PM +0300, Dan Carpenter wrote: > On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Thu, 4 Dec 2014 22:42:30 +0100 > > > > The data structure element "sha1" was assigned a null pointer by the > > mppe_alloc()

Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread SF Markus Elfring
>> The data structure element "sha1" was assigned a null pointer by the >> mppe_alloc() after a function call "crypto_alloc_hash" failed. > > This patch is also buggy. Do you really want to keep a variable reset after a detected failure? Regards, Markus -- To unsubscribe from this list: send

Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread Dan Carpenter
On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 4 Dec 2014 22:42:30 +0100 > > The data structure element "sha1" was assigned a null pointer by the > mppe_alloc() after a function call "crypto_alloc_hash" failed. This patch is also buggy.

Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread Dan Carpenter
On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 4 Dec 2014 22:42:30 +0100 The data structure element sha1 was assigned a null pointer by the mppe_alloc() after a function call crypto_alloc_hash failed. This

Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread SF Markus Elfring
The data structure element sha1 was assigned a null pointer by the mppe_alloc() after a function call crypto_alloc_hash failed. This patch is also buggy. Do you really want to keep a variable reset after a detected failure? Regards, Markus -- To unsubscribe from this list: send the line

Re: [PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-05 Thread Dan Carpenter
On Fri, Dec 05, 2014 at 03:23:15PM +0300, Dan Carpenter wrote: On Thu, Dec 04, 2014 at 11:20:21PM +0100, SF Markus Elfring wrote: From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 4 Dec 2014 22:42:30 +0100 The data structure element sha1 was assigned a null pointer by the

[PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-04 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 4 Dec 2014 22:42:30 +0100 The data structure element "sha1" was assigned a null pointer by the mppe_alloc() after a function call "crypto_alloc_hash" failed. It was determined that this element was not accessed by the implementation of the crypto_free_blkcipher()

[PATCH v2 6/6] net-PPP: Delete another unnecessary assignment in mppe_alloc()

2014-12-04 Thread SF Markus Elfring
From: Markus Elfring elfr...@users.sourceforge.net Date: Thu, 4 Dec 2014 22:42:30 +0100 The data structure element sha1 was assigned a null pointer by the mppe_alloc() after a function call crypto_alloc_hash failed. It was determined that this element was not accessed by the implementation of the