Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Alexander Duyck
On 05/20/2013 05:28 AM, Or Gerlitz wrote: > On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: > > >> I'm really not a fan of this. Seems to me the tail is wagging the dog >> here. Fix the driver to work without a PF driver being present. > Greg, Alex, > > As I wrote over the V1 thread, currently

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Ben Hutchings
On Mon, 2013-05-20 at 15:28 +0300, Or Gerlitz wrote: > On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: > > > > I'm really not a fan of this. Seems to me the tail is wagging the dog > > here. Fix the driver to work without a PF driver being present. > > Greg, Alex, > > As I wrote over the V

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Ben Hutchings
On Mon, 2013-05-20 at 15:58 +0300, Eliezer Tamir wrote: > On 20/05/2013 15:28, Or Gerlitz wrote: > > On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: > > > > > >> I'm really not a fan of this. Seems to me the tail is wagging the dog > >> here. Fix the driver to work without a PF driver being pr

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Yinghai Lu
On Mon, May 20, 2013 at 5:58 AM, Eliezer Tamir wrote: >> > Maybe do the following: > 1. split the VF PCI IDs into a separate PCI_ID device table. > 2. have two pci_driver structs, one for all of the PF IDS and one with the > VF IDS. > 3. only register the first pci_driver struct from mlx4_init().

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Eliezer Tamir
On 20/05/2013 15:28, Or Gerlitz wrote: On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: I'm really not a fan of this. Seems to me the tail is wagging the dog here. Fix the driver to work without a PF driver being present. Greg, Alex, As I wrote over the V1 thread, currently we can't go

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-20 Thread Or Gerlitz
On Wed, May 15, 2013 at 7:12 PM, Greg Rose wrote: > I'm really not a fan of this. Seems to me the tail is wagging the dog > here. Fix the driver to work without a PF driver being present. Greg, Alex, As I wrote over the V1 thread, currently we can't go and patch mlx4 to use the sysfs API nor

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-15 Thread Greg Rose
On Tue, 14 May 2013 19:48:22 -0700 Yinghai Lu wrote: > Found kernel try to load mlx4 drivers for VFs before > PF's is loaded when the drivers are built-in, and kernel > command line include probe_vfs=63, num_vfs=63. > > [ 169.581682] calling mlx4_init+0x0/0x119 @ 1 > [ 169.595681] mlx4_core:

Re: [PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Alexander Duyck
On 05/14/2013 07:48 PM, Yinghai Lu wrote: > Found kernel try to load mlx4 drivers for VFs before > PF's is loaded when the drivers are built-in, and kernel > command line include probe_vfs=63, num_vfs=63. > > [ 169.581682] calling mlx4_init+0x0/0x119 @ 1 > [ 169.595681] mlx4_core: Mellanox Conn

[PATCH v2 6/7] PCI: Make sure VF's driver get attached after PF's

2013-05-14 Thread Yinghai Lu
Found kernel try to load mlx4 drivers for VFs before PF's is loaded when the drivers are built-in, and kernel command line include probe_vfs=63, num_vfs=63. [ 169.581682] calling mlx4_init+0x0/0x119 @ 1 [ 169.595681] mlx4_core: Mellanox ConnectX core driver v1.1 (Dec, 2011) [ 169.600194] mlx4_