Re: [PATCH v2 6/9] net: bcmgenet: fix OF child-node lookup

2018-09-04 Thread Johan Hovold
On Thu, Aug 30, 2018 at 05:47:33PM -0700, Florian Fainelli wrote: > On 08/27/2018 01:21 AM, Johan Hovold wrote: > > Use the new of_get_compatible_child() helper to lookup the mdio child > > node instead of using of_find_compatible_node(), which searches the > > entire tree from a given start node a

Re: [PATCH v2 6/9] net: bcmgenet: fix OF child-node lookup

2018-08-30 Thread Florian Fainelli
On 08/27/2018 01:21 AM, Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the mdio child > node instead of using of_find_compatible_node(), which searches the > entire tree from a given start node and thus can return an unrelated > (i.e. non-child) node. > > This also ad

[PATCH v2 6/9] net: bcmgenet: fix OF child-node lookup

2018-08-27 Thread Johan Hovold
Use the new of_get_compatible_child() helper to lookup the mdio child node instead of using of_find_compatible_node(), which searches the entire tree from a given start node and thus can return an unrelated (i.e. non-child) node. This also addresses a potential use-after-free (e.g. after probe def