Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-15 Thread Jon Mason
On Thu, Oct 15, 2015 at 08:54:34PM +0200, Arnd Bergmann wrote: > On Thursday 15 October 2015 14:43:45 Jon Mason wrote: > > On Thu, Oct 15, 2015 at 11:36:19AM -0700, Scott Branden wrote: > > > Jon, > > > > > > Can you add this to your patchset and change COMMON_CLK_IPROC to a > > > silent option? >

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-15 Thread Arnd Bergmann
On Thursday 15 October 2015 14:43:45 Jon Mason wrote: > On Thu, Oct 15, 2015 at 11:36:19AM -0700, Scott Branden wrote: > > Jon, > > > > Can you add this to your patchset and change COMMON_CLK_IPROC to a > > silent option? > > Sure, I'll add this (and make it silent), as well as adding the > docum

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-15 Thread Jon Mason
On Thu, Oct 15, 2015 at 11:36:19AM -0700, Scott Branden wrote: > Jon, > > Can you add this to your patchset and change COMMON_CLK_IPROC to a > silent option? Sure, I'll add this (and make it silent), as well as adding the documentation patches back to this series (per Ray's suggestion), and will

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-15 Thread Scott Branden
Jon, Can you add this to your patchset and change COMMON_CLK_IPROC to a silent option? On 15-10-14 01:16 PM, Arnd Bergmann wrote: On Wednesday 14 October 2015 12:46:19 Scott Branden wrote: My patch fixes it by always selecting COMMON_CLK_IPROC from ARCH_BCM_CYGNUS. I wasn't sure whether you

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-14 Thread Arnd Bergmann
On Wednesday 14 October 2015 12:46:19 Scott Branden wrote: > > > > My patch fixes it by always selecting COMMON_CLK_IPROC from > > ARCH_BCM_CYGNUS. I wasn't sure whether you want COMMON_CLK_IPROC > > to still be user-selectable, so I left that in place. Normally > > I'd expect it to be a silent opt

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-14 Thread Scott Branden
On 15-10-13 03:23 PM, Arnd Bergmann wrote: On Tuesday 13 October 2015 18:04:50 Jon Mason wrote: On a related note, I'm seeing problems when CONFIG_CYGNUS is set but CONFIG_COMMON_CLK_IPROC is disabled, as that currently leads to a link failure. I can double check, but it should be on by defa

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 18:04:50 Jon Mason wrote: > > > On a related note, I'm seeing problems when CONFIG_CYGNUS is set but > > CONFIG_COMMON_CLK_IPROC is disabled, as that currently leads to a link > > failure. > > I can double check, but it should be on by default when Cygnus is > enabled.

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-13 Thread Jon Mason
On Tue, Oct 13, 2015 at 11:18:53PM +0200, Arnd Bergmann wrote: > On Tuesday 13 October 2015 17:08:05 Jon Mason wrote: > > @@ -3,6 +3,7 @@ obj-$(CONFIG_CLK_BCM_KONA) += clk-kona-setup.o > > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm281xx.o > > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm21664.o >

Re: [PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-13 Thread Arnd Bergmann
On Tuesday 13 October 2015 17:08:05 Jon Mason wrote: > @@ -3,6 +3,7 @@ obj-$(CONFIG_CLK_BCM_KONA) += clk-kona-setup.o > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm281xx.o > obj-$(CONFIG_CLK_BCM_KONA) += clk-bcm21664.o > obj-$(CONFIG_COMMON_CLK_IPROC) += clk-iproc-armpll.o clk-iproc-pll.o

[PATCH v2 7/7] clk: ns2: add clock support for Broadcom Northstar 2 SoC

2015-10-13 Thread Jon Mason
The Broadcom Northstar 2 SoC is architected under the iProc architecture. It has the following PLLs: GENPLL SCR, GENPLL SW, LCPLL DDR, LCPLL Ports, all derived from an onboard crystal. Signed-off-by: Jon Mason --- drivers/clk/Makefile| 2 +- drivers/clk/bcm/Makefile