Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 7, 2014 at 11:55 AM, Luis R. Rodriguez wrote: > OK I'll just kill bus.enable_kern_async=1 to enable built-in async > probe support *and* also have prefer_async_probe *always* be > respected, whether modular or not. Well and I just realized you *do* want to flush, so will throw that

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 7, 2014 at 10:55 AM, Tejun Heo wrote: > Hello, > > On Tue, Oct 07, 2014 at 07:50:10PM +0200, Luis R. Rodriguez wrote: >> On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: >> > But you can create a new workqueue and queue all the async probing >> > work items there and flush

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Tejun Heo
Hello, On Tue, Oct 07, 2014 at 07:50:10PM +0200, Luis R. Rodriguez wrote: > On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: > > But you can create a new workqueue and queue all the async probing > > work items there and flush the workqueue right after > > async_synchronize_full(). > >

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: > Hello, > > On Tue, Oct 07, 2014 at 01:10:46AM +0200, Luis R. Rodriguez wrote: > > On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: > > > For in-kernel stuff, we already have a clear > > > synchronization point where we already

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Tejun Heo
Hello, On Tue, Oct 07, 2014 at 01:10:46AM +0200, Luis R. Rodriguez wrote: > On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: > > For in-kernel stuff, we already have a clear > > synchronization point where we already synchronize all async calls. > > Shouldn't we be flushing these async

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Tejun Heo
Hello, On Tue, Oct 07, 2014 at 01:10:46AM +0200, Luis R. Rodriguez wrote: On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: For in-kernel stuff, we already have a clear synchronization point where we already synchronize all async calls. Shouldn't we be flushing these async probes

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: Hello, On Tue, Oct 07, 2014 at 01:10:46AM +0200, Luis R. Rodriguez wrote: On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: For in-kernel stuff, we already have a clear synchronization point where we already

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Tejun Heo
Hello, On Tue, Oct 07, 2014 at 07:50:10PM +0200, Luis R. Rodriguez wrote: On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: But you can create a new workqueue and queue all the async probing work items there and flush the workqueue right after async_synchronize_full(). On

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 7, 2014 at 10:55 AM, Tejun Heo t...@kernel.org wrote: Hello, On Tue, Oct 07, 2014 at 07:50:10PM +0200, Luis R. Rodriguez wrote: On Tue, Oct 07, 2014 at 01:34:04PM -0400, Tejun Heo wrote: But you can create a new workqueue and queue all the async probing work items there and

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-07 Thread Luis R. Rodriguez
On Tue, Oct 7, 2014 at 11:55 AM, Luis R. Rodriguez mcg...@suse.com wrote: OK I'll just kill bus.enable_kern_async=1 to enable built-in async probe support *and* also have prefer_async_probe *always* be respected, whether modular or not. Well and I just realized you *do* want to flush, so will

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Luis R. Rodriguez
On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: > Hello, > > On Mon, Oct 06, 2014 at 10:36:27PM +0200, Luis R. Rodriguez wrote: > > > Do we intend to keep this param permanently? Isn't this more of a > > > temp tool to be used during development? If so, maybe we should make > > >

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Tejun Heo
Hello, On Mon, Oct 06, 2014 at 10:36:27PM +0200, Luis R. Rodriguez wrote: > > Do we intend to keep this param permanently? Isn't this more of a > > temp tool to be used during development? If so, maybe we should make > > that clear with __DEVEL__ too? > > As its designed right now no, its not

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Dmitry Torokhov
Hi Luis, On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > At times we may wish to express the desire to prefer to have > a device driver probe asynchronously by default. We cannot > simply enable all device drivers to do this without vetting >

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Luis R. Rodriguez
On Mon, Oct 06, 2014 at 04:19:26PM -0400, Tejun Heo wrote: > Hello, Luis. > > The patchset generally looks good to me. Please feel free to add > > Reviewed-by: Tejun Heo Will do. > A question below. > > On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: > > +

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Tejun Heo
Hello, Luis. The patchset generally looks good to me. Please feel free to add Reviewed-by: Tejun Heo A question below. On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: > + bus.enable_kern_async=1 [KNL] > + This tells the kernel userspace has been

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Tejun Heo
Hello, Luis. The patchset generally looks good to me. Please feel free to add Reviewed-by: Tejun Heo t...@kernel.org A question below. On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: + bus.enable_kern_async=1 [KNL] + This tells the kernel

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Luis R. Rodriguez
On Mon, Oct 06, 2014 at 04:19:26PM -0400, Tejun Heo wrote: Hello, Luis. The patchset generally looks good to me. Please feel free to add Reviewed-by: Tejun Heo t...@kernel.org Will do. A question below. On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: +

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Dmitry Torokhov
Hi Luis, On Fri, Oct 03, 2014 at 02:44:43PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com At times we may wish to express the desire to prefer to have a device driver probe asynchronously by default. We cannot simply enable all device drivers to do this without

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Tejun Heo
Hello, On Mon, Oct 06, 2014 at 10:36:27PM +0200, Luis R. Rodriguez wrote: Do we intend to keep this param permanently? Isn't this more of a temp tool to be used during development? If so, maybe we should make that clear with __DEVEL__ too? As its designed right now no, its not a temp

Re: [PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-06 Thread Luis R. Rodriguez
On Mon, Oct 06, 2014 at 05:01:18PM -0400, Tejun Heo wrote: Hello, On Mon, Oct 06, 2014 at 10:36:27PM +0200, Luis R. Rodriguez wrote: Do we intend to keep this param permanently? Isn't this more of a temp tool to be used during development? If so, maybe we should make that clear with

[PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-03 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" At times we may wish to express the desire to prefer to have a device driver probe asynchronously by default. We cannot simply enable all device drivers to do this without vetting that userspace is prepared for this though given that some old userspace is expected to

[PATCH v2 7/7] driver-core: add preferred async probe option for built-in and modules

2014-10-03 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com At times we may wish to express the desire to prefer to have a device driver probe asynchronously by default. We cannot simply enable all device drivers to do this without vetting that userspace is prepared for this though given that some old userspace is