Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-12 Thread Sören Brinkmann
On Fri, 2014-12-05 at 09:08AM -0800, Sören Brinkmann wrote: > On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: > > > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > > > + .is_generic= true, > > >

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-05 Thread Sören Brinkmann
On Fri, 2014-12-05 at 09:08AM -0800, Sören Brinkmann wrote: > On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: > > > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > > > + .is_generic= true, > > >

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-05 Thread Sören Brinkmann
On Fri, 2014-12-05 at 09:59AM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > > + .is_generic= true, > > .pin_config_group_get= pmic_gpio_config_get, > > .pin_conf

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-04 Thread Ivan T. Ivanov
On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > static const struct pinconf_ops pmic_gpio_pinconf_ops = { > + .is_generic= true, > .pin_config_group_get= pmic_gpio_config_get, > .pin_config_group_set= pmic_gpio_config_set, > .pin_config_group_dbg_show=

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-04 Thread Sören Brinkmann
On Thu, 2014-12-04 at 11:30AM +0200, Ivan T. Ivanov wrote: > > On Wed, 2014-12-03 at 09:38 -0800, Sören Brinkmann wrote: > > On Wed, 2014-12-03 at 03:03PM +0200, Ivan T. Ivanov wrote: > > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > > Instead of the driver caring about impleme

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-04 Thread Ivan T. Ivanov
On Wed, 2014-12-03 at 09:38 -0800, Sören Brinkmann wrote: > On Wed, 2014-12-03 at 03:03PM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > > Instead of the driver caring about implementation details like device > > > tree, just provide information abou

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-03 Thread Sören Brinkmann
On Wed, 2014-12-03 at 03:03PM +0200, Ivan T. Ivanov wrote: > > On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > > Instead of the driver caring about implementation details like device > > tree, just provide information about driver specific pinconf parameters > > to pinconf-generic whic

Re: [PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-12-03 Thread Ivan T. Ivanov
On Thu, 2014-11-27 at 17:26 -0800, Soren Brinkmann wrote: > Instead of the driver caring about implementation details like device > tree, just provide information about driver specific pinconf parameters > to pinconf-generic which takes care of parsing the DT. > > Signed-off-by: Soren Brinkmann b

[PATCH v2 7/7] pinctrl: qcom-spmi-gpio: Migrate to pinconf-generic

2014-11-27 Thread Soren Brinkmann
Instead of the driver caring about implementation details like device tree, just provide information about driver specific pinconf parameters to pinconf-generic which takes care of parsing the DT. Signed-off-by: Soren Brinkmann --- This is compile tested only. So, it's likely that it needs more t