Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-17 Thread Ross Zwisler
On Sat, 2015-08-15 at 08:44 -0700, Dan Williams wrote: > On Sat, Aug 15, 2015 at 2:19 AM, Christoph Hellwig wrote: > > On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: > >> Update the annotation for the kaddr pointer returned by direct_access() > >> so that it is a __pmem pointer.

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-17 Thread Ross Zwisler
On Sat, 2015-08-15 at 08:44 -0700, Dan Williams wrote: On Sat, Aug 15, 2015 at 2:19 AM, Christoph Hellwig h...@lst.de wrote: On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer.

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 9:00 AM, Christoph Hellwig wrote: > On Sat, Aug 15, 2015 at 08:44:27AM -0700, Dan Williams wrote: >> That said, while we don't need special accessors we do need guarantees >> that anything that has written to a persistent memory address has done >> so in a way that

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Sat, Aug 15, 2015 at 08:44:27AM -0700, Dan Williams wrote: > That said, while we don't need special accessors we do need guarantees > that anything that has written to a persistent memory address has done > so in a way that wmb_pmem() is able to flush it. It's more of a "I've > audited this

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 2:11 AM, Christoph Hellwig wrote: > On Fri, Aug 14, 2015 at 09:58:16AM -0700, Dan Williams wrote: >> > I'll merge with your code for v3. >> >> Sounds, let me go rebase the __pfn_t patches on -mm so we'all lined up >> and collision free. > > I'm doubt that we'll have PFN

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 2:19 AM, Christoph Hellwig wrote: > On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: >> Update the annotation for the kaddr pointer returned by direct_access() >> so that it is a __pmem pointer. This is consistent with the PMEM driver >> and with how this

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: > Update the annotation for the kaddr pointer returned by direct_access() > so that it is a __pmem pointer. This is consistent with the PMEM driver > and with how this direct_access() pointer is used in the DAX code. IFF we stick to

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Fri, Aug 14, 2015 at 09:58:16AM -0700, Dan Williams wrote: > > I'll merge with your code for v3. > > Sounds, let me go rebase the __pfn_t patches on -mm so we'all lined up > and collision free. I'm doubt that we'll have PFN mapping ready for 4.3. I'd rather see Ross series goes first, and

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Fri, Aug 14, 2015 at 09:58:16AM -0700, Dan Williams wrote: I'll merge with your code for v3. Sounds, let me go rebase the __pfn_t patches on -mm so we'all lined up and collision free. I'm doubt that we'll have PFN mapping ready for 4.3. I'd rather see Ross series goes first, and move

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with how this direct_access() pointer is used in the DAX code. IFF we stick to the

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 9:00 AM, Christoph Hellwig h...@lst.de wrote: On Sat, Aug 15, 2015 at 08:44:27AM -0700, Dan Williams wrote: That said, while we don't need special accessors we do need guarantees that anything that has written to a persistent memory address has done so in a way that

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 2:19 AM, Christoph Hellwig h...@lst.de wrote: On Thu, Aug 13, 2015 at 10:51:11AM -0600, Ross Zwisler wrote: Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with how this

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Dan Williams
On Sat, Aug 15, 2015 at 2:11 AM, Christoph Hellwig h...@lst.de wrote: On Fri, Aug 14, 2015 at 09:58:16AM -0700, Dan Williams wrote: I'll merge with your code for v3. Sounds, let me go rebase the __pfn_t patches on -mm so we'all lined up and collision free. I'm doubt that we'll have PFN

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-15 Thread Christoph Hellwig
On Sat, Aug 15, 2015 at 08:44:27AM -0700, Dan Williams wrote: That said, while we don't need special accessors we do need guarantees that anything that has written to a persistent memory address has done so in a way that wmb_pmem() is able to flush it. It's more of a I've audited this code

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-14 Thread Dan Williams
On Fri, Aug 14, 2015 at 9:55 AM, Ross Zwisler wrote: > On Thu, 2015-08-13 at 14:20 -0700, Dan Williams wrote: >> On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler >> wrote: >> > Update the annotation for the kaddr pointer returned by direct_access() >> > so that it is a __pmem pointer. This is

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-14 Thread Ross Zwisler
On Thu, 2015-08-13 at 14:20 -0700, Dan Williams wrote: > On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler > wrote: > > Update the annotation for the kaddr pointer returned by direct_access() > > so that it is a __pmem pointer. This is consistent with the PMEM driver > > and with how this

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-14 Thread Dan Williams
On Fri, Aug 14, 2015 at 9:55 AM, Ross Zwisler ross.zwis...@linux.intel.com wrote: On Thu, 2015-08-13 at 14:20 -0700, Dan Williams wrote: On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler ross.zwis...@linux.intel.com wrote: Update the annotation for the kaddr pointer returned by direct_access()

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-14 Thread Ross Zwisler
On Thu, 2015-08-13 at 14:20 -0700, Dan Williams wrote: On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler ross.zwis...@linux.intel.com wrote: Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-13 Thread Dan Williams
On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler wrote: > Update the annotation for the kaddr pointer returned by direct_access() > so that it is a __pmem pointer. This is consistent with the PMEM driver > and with how this direct_access() pointer is used in the DAX code. > > Signed-off-by: Ross

[PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-13 Thread Ross Zwisler
Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with how this direct_access() pointer is used in the DAX code. Signed-off-by: Ross Zwisler --- Documentation/filesystems/Locking | 3 ++-

[PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-13 Thread Ross Zwisler
Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with how this direct_access() pointer is used in the DAX code. Signed-off-by: Ross Zwisler ross.zwis...@linux.intel.com ---

Re: [PATCH v2 7/7] pmem, dax: have direct_access use __pmem annotation

2015-08-13 Thread Dan Williams
On Thu, Aug 13, 2015 at 9:51 AM, Ross Zwisler ross.zwis...@linux.intel.com wrote: Update the annotation for the kaddr pointer returned by direct_access() so that it is a __pmem pointer. This is consistent with the PMEM driver and with how this direct_access() pointer is used in the DAX code.