Re: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator

2014-12-01 Thread Mark Brown
On Mon, Dec 01, 2014 at 11:19:25AM +0800, Flora Fu wrote: > On Fri, 2014-11-28 at 15:30 +, Mark Brown wrote: > > This appears to be the DT fragment for a SoC but you are defining the > > system integration for the PMIC. That's bad, the PMIC is a separate > > device so should be hooked up by

Re: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator

2014-11-30 Thread Sascha Hauer
On Mon, Dec 01, 2014 at 11:19:25AM +0800, Flora Fu wrote: > Hi, Mark, > > On Fri, 2014-11-28 at 15:30 +, Mark Brown wrote: > > On Fri, Nov 28, 2014 at 11:54:34AM +0800, Flora Fu wrote: > > > > > Add device tree for MT6397 regulators in mt8135.dtsi. > > > > > > Signed-off-by: Flora Fu > >

Re: [PATCH v2 8/8] ARM: dts: mt8135: Add support for MT6397 regulator

2014-11-28 Thread Mark Brown
On Fri, Nov 28, 2014 at 11:54:34AM +0800, Flora Fu wrote: > Add device tree for MT6397 regulators in mt8135.dtsi. > > Signed-off-by: Flora Fu > --- > arch/arm/boot/dts/mt8135.dtsi | 192 > ++ This appears to be the DT fragment for a SoC but you are defin