Re: [PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-10-09 Thread Paolo Bonzini
On 27/09/19 23:45, Sean Christopherson wrote: > Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common > cache_reg() callback and drop the dedicated decache_cr3(). The name > decache_cr3() is somewhat confusing as the caching behavior of CR3 > follows that of GPRs, RFLAGS and PDP

Re: [PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-30 Thread Sean Christopherson
On Mon, Sep 30, 2019 at 05:27:58PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > On Mon, Sep 30, 2019 at 12:58:53PM +0200, Vitaly Kuznetsov wrote: > >> Sean Christopherson writes: > >> > >> > Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common > >> > ca

Re: [PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > On Mon, Sep 30, 2019 at 12:58:53PM +0200, Vitaly Kuznetsov wrote: >> Sean Christopherson writes: >> >> > Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common >> > cache_reg() callback and drop the dedicated decache_cr3(). The name >> > decache_

Re: [PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-30 Thread Sean Christopherson
On Mon, Sep 30, 2019 at 12:58:53PM +0200, Vitaly Kuznetsov wrote: > Sean Christopherson writes: > > > Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common > > cache_reg() callback and drop the dedicated decache_cr3(). The name > > decache_cr3() is somewhat confusing as the ca

Re: [PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-30 Thread Vitaly Kuznetsov
Sean Christopherson writes: > Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common > cache_reg() callback and drop the dedicated decache_cr3(). The name > decache_cr3() is somewhat confusing as the caching behavior of CR3 > follows that of GPRs, RFLAGS and PDPTRs, (handled vi

[PATCH v2 8/8] KVM: x86: Fold decache_cr3() into cache_reg()

2019-09-27 Thread Sean Christopherson
Handle caching CR3 (from VMX's VMCS) into struct kvm_vcpu via the common cache_reg() callback and drop the dedicated decache_cr3(). The name decache_cr3() is somewhat confusing as the caching behavior of CR3 follows that of GPRs, RFLAGS and PDPTRs, (handled via cache_reg()), and has nothing in com