Re: [PATCH v2 8/8] x86/kaslr: Don't use 64-bit mem_vector for 32-bit kernel

2020-07-28 Thread Arvind Sankar
On Tue, Jul 28, 2020 at 12:37:12PM -0700, Kees Cook wrote: > On Mon, Jul 27, 2020 at 07:08:01PM -0400, Arvind Sankar wrote: > > Commit > > f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") > > converted mem_vector type to use 64-bit on the 32-bit kernel as well, > > based on Thomas's

Re: [PATCH v2 8/8] x86/kaslr: Don't use 64-bit mem_vector for 32-bit kernel

2020-07-28 Thread Kees Cook
On Mon, Jul 27, 2020 at 07:08:01PM -0400, Arvind Sankar wrote: > Commit > f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") > converted mem_vector type to use 64-bit on the 32-bit kernel as well, > based on Thomas's review [0]. However: > - the code still doesn't consistently use 64-bit

[PATCH v2 8/8] x86/kaslr: Don't use 64-bit mem_vector for 32-bit kernel

2020-07-27 Thread Arvind Sankar
Commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") converted mem_vector type to use 64-bit on the 32-bit kernel as well, based on Thomas's review [0]. However: - the code still doesn't consistently use 64-bit types. For instance, mem_avoid_overlap uses 32-bit types when checking