Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-14 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: > > Is this really supposed to be the commit message? > > Maybe it's ok when Linus said this. :-) > > Christoph is the maintainer of per-cpu. Well please make the changelog nice and understandable. -- To unsubscribe from this list: send the line "unsubscribe

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-14 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: Is this really supposed to be the commit message? Maybe it's ok when Linus said this. :-) Christoph is the maintainer of per-cpu. Well please make the changelog nice and understandable. -- To unsubscribe from this list: send the line unsubscribe

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-05 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: > > Is this really supposed to be the commit message? > > Maybe it's ok when Linus said this. :-) > > Christoph is the maintainer of per-cpu. Well please make the changelog nice and understandable. -- To unsubscribe from this list: send the line "unsubscribe

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-05 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: Is this really supposed to be the commit message? Maybe it's ok when Linus said this. :-) Christoph is the maintainer of per-cpu. Well please make the changelog nice and understandable. -- To unsubscribe from this list: send the line unsubscribe

Re: Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-03 Thread Sven Eckelmann
On Saturday 03 November 2012 12:58:45 Shan Wei wrote: > Sven Eckelmann said, at 2012/11/3 1:55: > > On Saturday 03 November 2012 00:02:06 Shan Wei wrote: > >> From: Shan Wei > >> > >> As Christoph Lameter said: > >>> In addition, following usage of per_cpu_ptr can be replaced by > >>>

Re: Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-03 Thread Sven Eckelmann
On Saturday 03 November 2012 12:58:45 Shan Wei wrote: Sven Eckelmann said, at 2012/11/3 1:55: On Saturday 03 November 2012 00:02:06 Shan Wei wrote: From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced by

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Shan Wei
Sven Eckelmann said, at 2012/11/3 1:55: > On Saturday 03 November 2012 00:02:06 Shan Wei wrote: >> From: Shan Wei >> >> As Christoph Lameter said: >>> In addition, following usage of per_cpu_ptr can be replaced by >>> this_cpu_read. >>> >>> cpu=get_cpu() >>> >>> *per_cpu_ptr(p,cpu) >>>

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Sven Eckelmann
On Saturday 03 November 2012 00:02:06 Shan Wei wrote: > From: Shan Wei > > As Christoph Lameter said: > > In addition, following usage of per_cpu_ptr can be replaced by > > this_cpu_read. > > > > cpu=get_cpu() > > > > *per_cpu_ptr(p,cpu) > > > > > > put_cpu() > > Right. > >

Re: [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: > diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h > index 897ba6a..3aef5b2 100644 > --- a/net/batman-adv/main.h > +++ b/net/batman-adv/main.h > @@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long > timestamp, > static inline

[PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Shan Wei
From: Shan Wei As Christoph Lameter said: > In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read. > > cpu=get_cpu() > > *per_cpu_ptr(p,cpu) > > > put_cpu() Right. Signed-off-by: Shan Wei --- net/batman-adv/main.h |4 +--- 1 files changed, 1

[PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Shan Wei
From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read. cpu=get_cpu() *per_cpu_ptr(p,cpu) put_cpu() Right. Signed-off-by: Shan Wei davids...@tencent.com --- net/batman-adv/main.h |

Re: [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Christoph Lameter
On Sat, 3 Nov 2012, Shan Wei wrote: diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h index 897ba6a..3aef5b2 100644 --- a/net/batman-adv/main.h +++ b/net/batman-adv/main.h @@ -263,9 +263,7 @@ static inline bool batadv_has_timed_out(unsigned long timestamp, static inline void

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Sven Eckelmann
On Saturday 03 November 2012 00:02:06 Shan Wei wrote: From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read. cpu=get_cpu() *per_cpu_ptr(p,cpu) put_cpu() Right.

Re: [B.A.T.M.A.N.] [PATCH v2 9/9] net: batman-adv: use per_cpu_add helper

2012-11-02 Thread Shan Wei
Sven Eckelmann said, at 2012/11/3 1:55: On Saturday 03 November 2012 00:02:06 Shan Wei wrote: From: Shan Wei davids...@tencent.com As Christoph Lameter said: In addition, following usage of per_cpu_ptr can be replaced by this_cpu_read. cpu=get_cpu() *per_cpu_ptr(p,cpu)