Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-08-31 Thread Josh Poimboeuf
On Tue, Aug 25, 2020 at 01:31:46PM +0100, Julien Thierry wrote: > > > > The call to update_cfi_state_regs() is really regs-specific, not > > > > sp-specific. > > > > > > > > > > I must admit I don't really understand what "regs" is and why exactly such > > > an exception in stack state tracking i

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-08-25 Thread Julien Thierry
On 8/3/20 10:35 PM, Josh Poimboeuf wrote: On Mon, Aug 03, 2020 at 01:13:14PM +0100, Julien Thierry wrote: On 7/31/20 3:04 PM, Josh Poimboeuf wrote: On Fri, Jul 31, 2020 at 08:00:58AM +0100, Julien Thierry wrote: + cfa->offset = hint->sp_offset; + insn->cfi.hint_type = hint->ty

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-08-03 Thread Josh Poimboeuf
On Mon, Aug 03, 2020 at 01:13:14PM +0100, Julien Thierry wrote: > > > On 7/31/20 3:04 PM, Josh Poimboeuf wrote: > > On Fri, Jul 31, 2020 at 08:00:58AM +0100, Julien Thierry wrote: > > > > > + cfa->offset = hint->sp_offset; > > > > > + insn->cfi.hint_type = hint->type; > > > > > + insn

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-08-03 Thread Julien Thierry
On 7/31/20 3:04 PM, Josh Poimboeuf wrote: On Fri, Jul 31, 2020 at 08:00:58AM +0100, Julien Thierry wrote: + cfa->offset = hint->sp_offset; + insn->cfi.hint_type = hint->type; + insn->cfi.end = hint->end; + + insn->cfi.sp_only = hint->type == ORC_TYPE_REGS || hint->type

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-07-31 Thread Josh Poimboeuf
On Fri, Jul 31, 2020 at 08:00:58AM +0100, Julien Thierry wrote: > > > + cfa->offset = hint->sp_offset; > > > + insn->cfi.hint_type = hint->type; > > > + insn->cfi.end = hint->end; > > > + > > > + insn->cfi.sp_only = hint->type == ORC_TYPE_REGS || hint->type == > > > ORC_TYPE_REGS_IRET; > > > > Wh

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-07-31 Thread Julien Thierry
On 7/30/20 4:03 PM, Josh Poimboeuf wrote: On Thu, Jul 30, 2020 at 10:46:52AM +0100, Julien Thierry wrote: The type of unwind hints and the semantics associated with them depend on the architecture. Let arch specific code convert unwind hints into objtool stack state descriptions. Signed-off-

Re: [PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-07-30 Thread Josh Poimboeuf
On Thu, Jul 30, 2020 at 10:46:52AM +0100, Julien Thierry wrote: > The type of unwind hints and the semantics associated with them depend > on the architecture. Let arch specific code convert unwind hints into > objtool stack state descriptions. > > Signed-off-by: Julien Thierry > --- > tools/obj

[PATCH v2 9/9] objtool: Abstract unwind hint reading

2020-07-30 Thread Julien Thierry
The type of unwind hints and the semantics associated with them depend on the architecture. Let arch specific code convert unwind hints into objtool stack state descriptions. Signed-off-by: Julien Thierry --- tools/objtool/arch.h| 5 +-- tools/objtool/arch/x86/decode.c | 54