Re: [PATCH v2 9/9] uprobes/x86: Teach arch_uprobe_post_xol() to restart if possible

2014-04-05 Thread Oleg Nesterov
On 04/04, Jim Keniston wrote: > > On Fri, 2014-04-04 at 20:51 +0200, Oleg Nesterov wrote: > > > > Currently only adjust_ret_addr() can fail, and this can only happen if > > another thread unmapped our stack after we executed "call" out-of-line. > > Most probably the application if buggy, but even i

Re: [PATCH v2 9/9] uprobes/x86: Teach arch_uprobe_post_xol() to restart if possible

2014-04-04 Thread Jim Keniston
On Fri, 2014-04-04 at 20:51 +0200, Oleg Nesterov wrote: > SIGILL after the failed arch_uprobe_post_xol() should only be used as > a last resort, we should try to restart the probed insn if possible. > > Currently only adjust_ret_addr() can fail, and this can only happen if > another thread unmappe

[PATCH v2 9/9] uprobes/x86: Teach arch_uprobe_post_xol() to restart if possible

2014-04-04 Thread Oleg Nesterov
SIGILL after the failed arch_uprobe_post_xol() should only be used as a last resort, we should try to restart the probed insn if possible. Currently only adjust_ret_addr() can fail, and this can only happen if another thread unmapped our stack after we executed "call" out-of-line. Most probably th