RE: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-25 Thread Wenyou.Yang
nyou Yang - A41535 > <wenyou.y...@microchip.com> > Subject: Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor- > based gpio APIs correctly > > On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > >

RE: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-25 Thread Wenyou.Yang
> -Original Message- > From: Greg Kroah-Hartman [mailto:gre...@linuxfoundation.org] > Sent: 2016年12月24日 2:05 > To: Peter Rosin > Cc: linux-kernel@vger.kernel.org; Alan Stern ; > linux-...@vger.kernel.org; Wenyou Yang - A41535 > > Subject: Re: [PATCH v2 REGRESSIO

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-23 Thread Greg Kroah-Hartman
On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > >> The gpiod_get* function family does not want the -gpio suffix. > >> Use devm_gpiod_get_index_optional instead of

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-23 Thread Greg Kroah-Hartman
On Thu, Dec 22, 2016 at 09:38:08PM +0100, Peter Rosin wrote: > On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > >> The gpiod_get* function family does not want the -gpio suffix. > >> Use devm_gpiod_get_index_optional instead of

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Peter Rosin
On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: >> The gpiod_get* function family does not want the -gpio suffix. >> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. >> The descriptor based APIs handle active

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Peter Rosin
On 2016-12-22 18:27, Greg Kroah-Hartman wrote: > On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: >> The gpiod_get* function family does not want the -gpio suffix. >> Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. >> The descriptor based APIs handle active

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Greg Kroah-Hartman
On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > The gpiod_get* function family does not want the -gpio suffix. > Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. > The descriptor based APIs handle active high/low automatically. > The vbus-gpios are output,

Re: [PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Greg Kroah-Hartman
On Thu, Dec 22, 2016 at 08:43:55AM +0100, Peter Rosin wrote: > The gpiod_get* function family does not want the -gpio suffix. > Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. > The descriptor based APIs handle active high/low automatically. > The vbus-gpios are output,

[PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Peter Rosin
The gpiod_get* function family does not want the -gpio suffix. Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. The descriptor based APIs handle active high/low automatically. The vbus-gpios are output, request enable while getting the gpio. Don't try to get any vbus-gpios for

[PATCH v2 REGRESSION RESEND] usb: ohci-at91: use descriptor-based gpio APIs correctly

2016-12-22 Thread Peter Rosin
The gpiod_get* function family does not want the -gpio suffix. Use devm_gpiod_get_index_optional instead of devm_gpiod_get_optional. The descriptor based APIs handle active high/low automatically. The vbus-gpios are output, request enable while getting the gpio. Don't try to get any vbus-gpios for