Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-25 Thread Sudip Mukherjee
On Sat, Apr 25, 2015 at 11:39:29AM +0530, Sudip Mukherjee wrote: > On Fri, Apr 24, 2015 at 07:37:02PM +0100, One Thousand Gnomes wrote: > > > Let me know when you have a set of patches you feel are good for testing > > and I'll give them a go. > This series of WIP is also good for testing. well,

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread Sudip Mukherjee
On Fri, Apr 24, 2015 at 07:37:02PM +0100, One Thousand Gnomes wrote: Hi Alan, > On Fri, 24 Apr 2015 13:08:25 +0530 > Sudip Mukherjee wrote: > > > On Fri, Apr 24, 2015 at 09:26:08AM +0200, Greg KH wrote: > > > On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > > > > What does dd

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread One Thousand Gnomes
On Fri, 24 Apr 2015 13:08:25 +0530 Sudip Mukherjee wrote: > On Fri, Apr 24, 2015 at 09:26:08AM +0200, Greg KH wrote: > > On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > > > What does ddev stand for? Anyway, it's probably better to call it > > > > bus_dev? > > > ok. > > > I t

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread Sudip Mukherjee
On Fri, Apr 24, 2015 at 10:04:54AM +0300, Dan Carpenter wrote: > On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > > What is the point of the check function really? The name isn't clear. > > yes, i am a bit blunt in thinking of new names, i hope you have noticed > > that in my n

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread Sudip Mukherjee
On Fri, Apr 24, 2015 at 09:26:08AM +0200, Greg KH wrote: > On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > > What does ddev stand for? Anyway, it's probably better to call it > > > bus_dev? > > ok. > > I think I will wait today for some comments from Greg and then send in > >

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread Greg KH
On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > What does ddev stand for? Anyway, it's probably better to call it > > bus_dev? > ok. > I think I will wait today for some comments from Greg and then send in > the v3 tomorrow. Don't wait for me, it's going to be a week or so at

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-24 Thread Dan Carpenter
On Fri, Apr 24, 2015 at 12:20:26PM +0530, Sudip Mukherjee wrote: > > What is the point of the check function really? The name isn't clear. > yes, i am a bit blunt in thinking of new names, i hope you have noticed > that in my naming of the labels .. :) > > as the name was not sufficient i mention

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-23 Thread Sudip Mukherjee
On Thu, Apr 23, 2015 at 06:18:37PM +0300, Dan Carpenter wrote: > On Tue, Apr 21, 2015 at 07:22:34PM +0530, Sudip Mukherjee wrote: > > .owner = NULL, > > }; > > > > +struct bus_type parport_bus_type = { > > + .name = "parport", > > +}; > > Can you make this static? The

Re: [PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-23 Thread Dan Carpenter
On Tue, Apr 21, 2015 at 07:22:34PM +0530, Sudip Mukherjee wrote: > This is again another WIP for your review. > almost all the points raised by Greg and Dan has been covered in this > patch. > > apart from those points, I found another problem with my previous code, > that whenever any driver is t

[PATCH v2 WIP 1/2] parport: add device-model to parport subsystem

2015-04-21 Thread Sudip Mukherjee
This is again another WIP for your review. almost all the points raised by Greg and Dan has been covered in this patch. apart from those points, I found another problem with my previous code, that whenever any driver is trying to register, it is getting bound to all the available parallel ports. T