Re: [PATCH v2 bpf-next 11/13] bpf: Add bitwise atomic instructions

2020-11-30 Thread Yonghong Song
On 11/28/20 5:36 PM, Alexei Starovoitov wrote: On Fri, Nov 27, 2020 at 09:39:10PM -0800, Yonghong Song wrote: On 11/27/20 9:57 AM, Brendan Jackman wrote: This adds instructions for atomic[64]_[fetch_]and atomic[64]_[fetch_]or atomic[64]_[fetch_]xor All these operations are isomorphic eno

Re: [PATCH v2 bpf-next 11/13] bpf: Add bitwise atomic instructions

2020-11-28 Thread Alexei Starovoitov
On Fri, Nov 27, 2020 at 09:39:10PM -0800, Yonghong Song wrote: > > > On 11/27/20 9:57 AM, Brendan Jackman wrote: > > This adds instructions for > > > > atomic[64]_[fetch_]and > > atomic[64]_[fetch_]or > > atomic[64]_[fetch_]xor > > > > All these operations are isomorphic enough to implement wit

Re: [PATCH v2 bpf-next 11/13] bpf: Add bitwise atomic instructions

2020-11-28 Thread Yonghong Song
On 11/27/20 9:57 AM, Brendan Jackman wrote: This adds instructions for atomic[64]_[fetch_]and atomic[64]_[fetch_]or atomic[64]_[fetch_]xor All these operations are isomorphic enough to implement with the same verifier, interpreter, and x86 JIT code, hence being a single commit. The main int

[PATCH v2 bpf-next 11/13] bpf: Add bitwise atomic instructions

2020-11-27 Thread Brendan Jackman
This adds instructions for atomic[64]_[fetch_]and atomic[64]_[fetch_]or atomic[64]_[fetch_]xor All these operations are isomorphic enough to implement with the same verifier, interpreter, and x86 JIT code, hence being a single commit. The main interesting thing here is that x86 doesn't directly