Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-27 Thread Roman Gushchin
On Tue, Dec 26, 2017 at 06:32:05PM -0800, Alexei Starovoitov wrote: > On Fri, Dec 22, 2017 at 06:50:01PM +, Quentin Monnet wrote: > > Hi Roman, > > > > 2017-12-22 16:11 UTC+ ~ Roman Gushchin > > > Bpftool build is broken with binutils version 2.28 and later. > > > > Could

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-27 Thread Roman Gushchin
On Tue, Dec 26, 2017 at 06:32:05PM -0800, Alexei Starovoitov wrote: > On Fri, Dec 22, 2017 at 06:50:01PM +, Quentin Monnet wrote: > > Hi Roman, > > > > 2017-12-22 16:11 UTC+ ~ Roman Gushchin > > > Bpftool build is broken with binutils version 2.28 and later. > > > > Could you check the

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-26 Thread Alexei Starovoitov
On Fri, Dec 22, 2017 at 06:50:01PM +, Quentin Monnet wrote: > Hi Roman, > > 2017-12-22 16:11 UTC+ ~ Roman Gushchin > > Bpftool build is broken with binutils version 2.28 and later. > > Could you check the binutils version? I believe it changed in 2.29 > instead of 2.28.

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-26 Thread Alexei Starovoitov
On Fri, Dec 22, 2017 at 06:50:01PM +, Quentin Monnet wrote: > Hi Roman, > > 2017-12-22 16:11 UTC+ ~ Roman Gushchin > > Bpftool build is broken with binutils version 2.28 and later. > > Could you check the binutils version? I believe it changed in 2.29 > instead of 2.28. Could you update

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-22 Thread Quentin Monnet
Hi Roman, 2017-12-22 16:11 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. Could you check the binutils version? I believe it changed in 2.29 instead of 2.28. Could you update your commit log and subject accordingly, please? > The cause is

Re: [PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-22 Thread Quentin Monnet
Hi Roman, 2017-12-22 16:11 UTC+ ~ Roman Gushchin > Bpftool build is broken with binutils version 2.28 and later. Could you check the binutils version? I believe it changed in 2.29 instead of 2.28. Could you update your commit log and subject accordingly, please? > The cause is commit

[PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-22 Thread Roman Gushchin
Bpftool build is broken with binutils version 2.28 and later. The cause is commit 003ca0fd2286 ("Refactor disassembler selection") in the binutils repo, which changed the disassembler() function signature. Fix this by adding a new "feature" to the tools/build/features infrastructure and make it

[PATCH v2 bpf-next 2/2] tools/bpftool: fix bpftool build with bintutils >= 2.8

2017-12-22 Thread Roman Gushchin
Bpftool build is broken with binutils version 2.28 and later. The cause is commit 003ca0fd2286 ("Refactor disassembler selection") in the binutils repo, which changed the disassembler() function signature. Fix this by adding a new "feature" to the tools/build/features infrastructure and make it