Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-17 Thread Geert Uytterhoeven
On Tue, Nov 17, 2015 at 10:02 AM, Geert Uytterhoeven wrote: > On Fri, Nov 13, 2015 at 1:26 AM, Florian Fainelli > wrote: >> On 04/11/15 18:56, David Miller wrote: Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") >>> ... Reported-by: Niko

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-17 Thread Geert Uytterhoeven
On Fri, Nov 13, 2015 at 1:26 AM, Florian Fainelli wrote: > On 04/11/15 18:56, David Miller wrote: >>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >>> features down stack") >> ... >>> Reported-by: Nikolay Aleksandrov >>> Signed-off-by: Jarod Wilson >>> --- >>> v2: Based

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Laura Abbott
On 11/13/2015 02:51 AM, Nikolay Aleksandrov wrote: On 11/13/2015 11:29 AM, Jiri Pirko wrote: Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: On 04/11/15 18:56, David Miller wrote: Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") ..

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Nikolay Aleksandrov
On 11/13/2015 11:29 AM, Jiri Pirko wrote: > Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >> On 04/11/15 18:56, David Miller wrote: Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack") >>> ... Reported-by: Nikolay Aleksandrov

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-13 Thread Jiri Pirko
Fri, Nov 13, 2015 at 01:26:18AM CET, f.faine...@gmail.com wrote: >On 04/11/15 18:56, David Miller wrote: >>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >>> features down stack") >> ... >>> Reported-by: Nikolay Aleksandrov >>> Signed-off-by: Jarod Wilson >>> --- >>> v2:

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-12 Thread Florian Fainelli
On 04/11/15 18:56, David Miller wrote: >> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev >> features down stack") > ... >> Reported-by: Nikolay Aleksandrov >> Signed-off-by: Jarod Wilson >> --- >> v2: Based on suggestions from Alex, and with not changing err to ret, this >

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-04 Thread David Miller
From: Jarod Wilson Date: Tue, 3 Nov 2015 23:09:32 -0500 > With moving netdev_sync_lower_features() after the .ndo_set_features > calls, I neglected to verify that devices added *after* a flag had been > disabled on an upper device were properly added with that flag disabled as > well. This curre

[PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

2015-11-03 Thread Jarod Wilson
With moving netdev_sync_lower_features() after the .ndo_set_features calls, I neglected to verify that devices added *after* a flag had been disabled on an upper device were properly added with that flag disabled as well. This currently happens, because we exit __netdev_update_features() when we se