RE: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving

2012-10-23 Thread hayeswang
Francois Romieu [mailto:rom...@fr.zoreil.com] [...] > > +static void r810x_aldps_disable(struct rtl8169_private *tp) > > +{ > > + rtl_writephy(tp, 0x1f, 0x); > > + rtl_writephy(tp, 0x18, 0x0310); > > + msleep(100); > > +} > > rtl8402_hw_phy_config used a msleep(20). Meguesses it won't

Re: [PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving

2012-10-23 Thread Francois Romieu
Hayes Wang : > Enable ALDPS function to save power when link down. Note that the > feature should be set after the other PHY settings. And the firmware > is necessary. Don't enable it without loading the firmware. > > Signed-off-by: Hayes Wang [...] Please see my just sent answer in yesterday's

[PATCH v2 net-next 1/2] r8169: enable ALDPS for power saving

2012-10-22 Thread Hayes Wang
Enable ALDPS function to save power when link down. Note that the feature should be set after the other PHY settings. And the firmware is necessary. Don't enable it without loading the firmware. Signed-off-by: Hayes Wang --- drivers/net/ethernet/realtek/r8169.c | 62 +