Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Alexander Lobakin
From: Dmitry Vyukov Date: Thu, 14 Jan 2021 13:51:44 +0100 > On Thu, Jan 14, 2021 at 1:50 PM Dmitry Vyukov wrote: >> >> On Thu, Jan 14, 2021 at 1:44 PM Alexander Lobakin wrote: >>> >>> From: Dmitry Vyukov >>> Date: Thu, 14 Jan 2021 12:47:31 +0100 >>> On Thu, Jan 14, 2021 at 12:41 PM Alexan

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Dmitry Vyukov
On Thu, Jan 14, 2021 at 2:00 PM Alexander Lobakin wrote: > >> Instead of calling kmem_cache_alloc() every time when building a NAPI > >> skb, (re)use skbuff_heads from napi_alloc_cache.skb_cache. Previously > >> this cache was only used for bulk-freeing skbuff_heads consumed via >

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Alexander Lobakin
From: Dmitry Vyukov Date: Thu, 14 Jan 2021 13:50:25 +0100 > On Thu, Jan 14, 2021 at 1:44 PM Alexander Lobakin wrote: >> >> From: Dmitry Vyukov >> Date: Thu, 14 Jan 2021 12:47:31 +0100 >> >>> On Thu, Jan 14, 2021 at 12:41 PM Alexander Lobakin wrote: From: Eric Dumazet Date: Wed,

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Dmitry Vyukov
On Thu, Jan 14, 2021 at 1:50 PM Dmitry Vyukov wrote: > > On Thu, Jan 14, 2021 at 1:44 PM Alexander Lobakin wrote: > > > > From: Dmitry Vyukov > > Date: Thu, 14 Jan 2021 12:47:31 +0100 > > > > > On Thu, Jan 14, 2021 at 12:41 PM Alexander Lobakin wrote: > > >> > > >> From: Eric Dumazet > > >> Da

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Dmitry Vyukov
On Thu, Jan 14, 2021 at 1:44 PM Alexander Lobakin wrote: > > From: Dmitry Vyukov > Date: Thu, 14 Jan 2021 12:47:31 +0100 > > > On Thu, Jan 14, 2021 at 12:41 PM Alexander Lobakin wrote: > >> > >> From: Eric Dumazet > >> Date: Wed, 13 Jan 2021 15:36:05 +0100 > >> > >>> On Wed, Jan 13, 2021 at 2:3

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Alexander Lobakin
From: Dmitry Vyukov Date: Thu, 14 Jan 2021 12:47:31 +0100 > On Thu, Jan 14, 2021 at 12:41 PM Alexander Lobakin wrote: >> >> From: Eric Dumazet >> Date: Wed, 13 Jan 2021 15:36:05 +0100 >> >>> On Wed, Jan 13, 2021 at 2:37 PM Alexander Lobakin wrote: Instead of calling kmem_cache_alloc(

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Dmitry Vyukov
On Thu, Jan 14, 2021 at 12:41 PM Alexander Lobakin wrote: > > From: Eric Dumazet > Date: Wed, 13 Jan 2021 15:36:05 +0100 > > > On Wed, Jan 13, 2021 at 2:37 PM Alexander Lobakin wrote: > >> > >> Instead of calling kmem_cache_alloc() every time when building a NAPI > >> skb, (re)use skbuff_heads f

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-14 Thread Alexander Lobakin
From: Eric Dumazet Date: Wed, 13 Jan 2021 15:36:05 +0100 > On Wed, Jan 13, 2021 at 2:37 PM Alexander Lobakin wrote: >> >> Instead of calling kmem_cache_alloc() every time when building a NAPI >> skb, (re)use skbuff_heads from napi_alloc_cache.skb_cache. Previously >> this cache was only used for

Re: [PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-13 Thread Eric Dumazet
On Wed, Jan 13, 2021 at 2:37 PM Alexander Lobakin wrote: > > Instead of calling kmem_cache_alloc() every time when building a NAPI > skb, (re)use skbuff_heads from napi_alloc_cache.skb_cache. Previously > this cache was only used for bulk-freeing skbuff_heads consumed via > napi_consume_skb() or _

[PATCH v2 net-next 2/3] skbuff: (re)use NAPI skb cache on allocation path

2021-01-13 Thread Alexander Lobakin
Instead of calling kmem_cache_alloc() every time when building a NAPI skb, (re)use skbuff_heads from napi_alloc_cache.skb_cache. Previously this cache was only used for bulk-freeing skbuff_heads consumed via napi_consume_skb() or __kfree_skb_defer(). Typical path is: - skb is queued for freeing f