Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-30 Thread Krzysztof Kozlowski
On Sun, Nov 29, 2020 at 06:55:10PM +0900, Bongsu Jeon wrote: > On Sat, Nov 28, 2020 at 9:49 PM Krzysztof Kozlowski wrote: > > This is not a proper wrapping. Wrapping happens on function arguments. > > > > > + if (!gpio_is_valid(phy->common.gpio_en)) > > > return

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-29 Thread Bongsu Jeon
On Sat, Nov 28, 2020 at 9:49 PM Krzysztof Kozlowski wrote: > > On Fri, Nov 27, 2020 at 08:22:18PM +0900, bongsu.je...@gmail.com wrote: > > From: Bongsu Jeon > > > > Extract the common phy blocks to reuse it. > > The UART module will use the common blocks. > > > > Signed-off-by: Bongsu Jeon > >

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-28 Thread Krzysztof Kozlowski
On Fri, Nov 27, 2020 at 08:22:18PM +0900, bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > Changes in v2: > - remove the common function's definition in common

Re: [PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-27 Thread Jakub Kicinski
On Fri, 27 Nov 2020 20:22:18 +0900 bongsu.je...@gmail.com wrote: > From: Bongsu Jeon > > Extract the common phy blocks to reuse it. > The UART module will use the common blocks. > > Signed-off-by: Bongsu Jeon > --- > Changes in v2: > - remove the common function's definition in common header

[PATCH v2 net-next 3/3] nfc: s3fwrn5: extract the common phy blocks

2020-11-27 Thread bongsu . jeon2
From: Bongsu Jeon Extract the common phy blocks to reuse it. The UART module will use the common blocks. Signed-off-by: Bongsu Jeon --- Changes in v2: - remove the common function's definition in common header file. - make the common phy_common.c file to define the common function. - wrap