On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote:
> Joe Perches writes:
[]
> > These might be better without the automatic use of ret
> >
> > return !gpio_get_value(CORGI_GPIO_AC_IN) ||
> > !gpio_get_value(CORGI_GPIO_KEY_INT) ||
> >
On Mon, 2016-08-01 at 00:04 +0200, Robert Jarzmik wrote:
> Joe Perches writes:
[]
> > These might be better without the automatic use of ret
> >
> > return !gpio_get_value(CORGI_GPIO_AC_IN) ||
> > !gpio_get_value(CORGI_GPIO_KEY_INT) ||
> >
Hi Joe,
Joe Perches writes:
> trivially:
>> diff --git a/arch/arm/mach-pxa/corgi_pm.c b/arch/arm/mach-pxa/corgi_pm.c
> []
>> @@ -131,15 +131,13 @@ static int corgi_should_wakeup(unsigned int
>> resume_on_alarm)
>> return is_resume;
>> }
>>
>> -static unsigned long
Hi Joe,
Joe Perches writes:
> trivially:
>> diff --git a/arch/arm/mach-pxa/corgi_pm.c b/arch/arm/mach-pxa/corgi_pm.c
> []
>> @@ -131,15 +131,13 @@ static int corgi_should_wakeup(unsigned int
>> resume_on_alarm)
>> return is_resume;
>> }
>>
>> -static unsigned long
On Sun, 2016-07-31 at 14:17 +0200, Robert Jarzmik wrote:
> The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of
> gpio register") from Oct 17, 2011, leads to the following static checker
> warning:
> arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup()
> warn: double
On Sun, 2016-07-31 at 14:17 +0200, Robert Jarzmik wrote:
> The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of
> gpio register") from Oct 17, 2011, leads to the following static checker
> warning:
> arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup()
> warn: double
The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of
gpio register") from Oct 17, 2011, leads to the following static checker
warning:
arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup()
warn: double left shift '!gpio_get_value(SPITZ_GPIO_KEY_INT)
<< (1 <<
The commit 9bf448c66d4b ("ARM: pxa: use generic gpio operation instead of
gpio register") from Oct 17, 2011, leads to the following static checker
warning:
arch/arm/mach-pxa/spitz_pm.c:172 spitz_charger_wakeup()
warn: double left shift '!gpio_get_value(SPITZ_GPIO_KEY_INT)
<< (1 <<
8 matches
Mail list logo