Re: [PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-18 Thread Brian Austin
On Tue, 18 Mar 2014, Mark Brown wrote: On Tue, Mar 18, 2014 at 12:08:02PM -0500, Paul Handrigan wrote: On Tue, 18 Mar 2014, Brian Austin wrote: Driver looks good to me. I think we should name it the cs42xx8 since this actually covers CS42448 and CS42888. The CS42888 is derived from the CS4

Re: [PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-18 Thread Mark Brown
On Tue, Mar 18, 2014 at 12:08:02PM -0500, Paul Handrigan wrote: > On Tue, 18 Mar 2014, Brian Austin wrote: > >Driver looks good to me. I think we should name it the cs42xx8 since this > >actually covers CS42448 and CS42888. The CS42888 is derived from the > >CS42448. > V3 looks good. As Brian sai

Re: [PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-18 Thread Paul Handrigan
On Tue, 18 Mar 2014, Brian Austin wrote: On Tue, 18 Mar 2014, Mark Brown wrote: On Tue, Mar 11, 2014 at 07:41:31PM +0800, Nicolin Chen wrote: This patch adds support for the Cirrus Logic CS42888 Audio CODEC that has four 24-bit A/D and eight 24-bit D/A converters. Brian, Paul - any review

Re: [PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-18 Thread Brian Austin
On Tue, 18 Mar 2014, Mark Brown wrote: On Tue, Mar 11, 2014 at 07:41:31PM +0800, Nicolin Chen wrote: This patch adds support for the Cirrus Logic CS42888 Audio CODEC that has four 24-bit A/D and eight 24-bit D/A converters. Brian, Paul - any review comments on this? Driver looks good to me.

Re: [PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-18 Thread Mark Brown
On Tue, Mar 11, 2014 at 07:41:31PM +0800, Nicolin Chen wrote: > This patch adds support for the Cirrus Logic CS42888 Audio CODEC that > has four 24-bit A/D and eight 24-bit D/A converters. Brian, Paul - any review comments on this? signature.asc Description: Digital signature

[PATCH v3] ASoC: cs42888: Add codec driver support

2014-03-11 Thread Nicolin Chen
This patch adds support for the Cirrus Logic CS42888 Audio CODEC that has four 24-bit A/D and eight 24-bit D/A converters. [ CS42888 supports both I2C and SPI control ports. As initial patch, this patch only adds the support for I2C. ] Signed-off-by: Nicolin Chen --- Changelog v3: * Refined