Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-18 Thread PC Liao
Hi Mark, On Mon, 2016-04-18 at 20:03 +0800, Mark Brown wrote: > On Mon, Apr 18, 2016 at 07:36:20PM +0800, PC Liao wrote: > > > Could you please give some comments or suggestions? > > I don't have these patches. If you're getting review comments from > other people please address them, it's quit

Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-18 Thread Mark Brown
On Mon, Apr 18, 2016 at 07:36:20PM +0800, PC Liao wrote: > Could you please give some comments or suggestions? I don't have these patches. If you're getting review comments from other people please address them, it's quite possible I saw them and agreed with them. Please don't send content free

Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-18 Thread PC Liao
Hi Mark, On Thu, 2016-04-07 at 15:35 +0800, PC Liao wrote: > This patch adds second I2S connection to rt5650 codec for capture path on > mt8173-rt5650 machine driver. > > Signed-off-by: PC Liao > --- > Changes since v2: > Use sound-dai to determine the capture path. > --- > .../devicetree/bindi

Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-07 Thread PC Liao
Hi Matthias, On Thu, 2016-04-07 at 17:50 +0800, Matthias Brugger wrote: > > On 07/04/16 09:35, PC Liao wrote: > > diff --git a/sound/soc/mediatek/mt8173-rt5650.c > > b/sound/soc/mediatek/mt8173-rt5650.c > > index bb09bb1..9f56df9 100644 > > --- a/sound/soc/mediatek/mt8173-rt5650.c > > +++ b/soun

Re: [PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-07 Thread Matthias Brugger
On 07/04/16 09:35, PC Liao wrote: This patch adds second I2S connection to rt5650 codec for capture path on mt8173-rt5650 machine driver. Signed-off-by: PC Liao --- Changes since v2: Use sound-dai to determine the capture path. --- .../devicetree/bindings/sound/mt8173-rt5650.txt|6 +

[PATCH v3] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

2016-04-07 Thread PC Liao
This patch adds second I2S connection to rt5650 codec for capture path on mt8173-rt5650 machine driver. Signed-off-by: PC Liao --- Changes since v2: Use sound-dai to determine the capture path. --- .../devicetree/bindings/sound/mt8173-rt5650.txt|6 +++ sound/soc/mediatek/mt8173-rt5650.c