Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Wed, Feb 14, 2018 at 10:41 PM, Andy Shevchenko wrote: > On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng wrote: >> On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: >>> On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Wed, Feb 14, 2018 at 10:41 PM, Andy Shevchenko wrote: > On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng wrote: >> On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: >>> On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > >> Hi Mark, do you know the way to disable gmail word wrap in

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng wrote: > On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: >> On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > Hi Mark, do you know the way to disable gmail word wrap in plain text mode? >

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Wed, Feb 14, 2018 at 4:39 PM, Donglin Peng wrote: > On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: >> On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > Hi Mark, do you know the way to disable gmail word wrap in plain text mode? > I find that gmail will force to wrap word at

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: > On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > >> --- a/sound/soc/soc-core.c >> +++ b/sound/soc/soc-core.c >> @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct >> snd_soc_component *component) >>

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Mon, Feb 12, 2018 at 7:49 PM, Mark Brown wrote: > On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > >> --- a/sound/soc/soc-core.c >> +++ b/sound/soc/soc-core.c >> @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct >> snd_soc_component *component) >> "ASoC:

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Mon, Feb 12, 2018 at 3:49 AM, Mark Brown wrote: > On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > >> --- a/sound/soc/soc-core.c >> +++ b/sound/soc/soc-core.c >> @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct >> snd_soc_component *component) >>

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Mon, Feb 12, 2018 at 3:49 AM, Mark Brown wrote: > On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > >> --- a/sound/soc/soc-core.c >> +++ b/sound/soc/soc-core.c >> @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct >> snd_soc_component *component) >> "ASoC:

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct > snd_soc_component *component) > "ASoC: Failed to create codec register debugfs file\n"); Your

Re: [PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

On Fri, Feb 09, 2018 at 11:10:55PM +0800, Donglin Peng wrote: > --- a/sound/soc/soc-core.c > +++ b/sound/soc/soc-core.c > @@ -349,7 +349,7 @@ static void soc_init_codec_debugfs(struct > snd_soc_component *component) > "ASoC: Failed to create codec register debugfs file\n"); Your

[PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

There is some duplicate code in soc-core.c, and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. Signed-off-by: Peng Donglin Reviewed-by: Andy Shevchenko --- v3: [addressed comments from Andy] * add

[PATCH v3] ASoC: use DEFINE_SHOW_ATTRIBUTE() to decrease code duplication

There is some duplicate code in soc-core.c, and the kernel provides DEFINE_SHOW_ATTRIBUTE() helper macro to decrease it in seq_file.h. Signed-off-by: Peng Donglin Reviewed-by: Andy Shevchenko --- v3: [addressed comments from Andy] * add missing tag v2: [addressed comments from Andy] * modify