Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Rushikesh S Kadam
Hi Nick, Joe thanks for your comments Regards Rushikesh On Mon, Apr 01, 2019 at 03:17:13PM -0600, Nick Crews wrote: > I tried to send the last message from my phone, and surprise it wasn't > formatted correctly, so it may have been marked as spam. repeating > myself again... > > Ah, I guess I

Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-04-01 Thread Nick Crews
I tried to send the last message from my phone, and surprise it wasn't formatted correctly, so it may have been marked as spam. repeating myself again... Ah, I guess I was wrong about logging OOM. I hadn’t hear about the recommendations against it, but they make sense. Thanks for the

Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-30 Thread Joe Perches
On Sat, 2019-03-30 at 15:52 +0530, Rushikesh S Kadam wrote: > On Fri, Mar 29, 2019 at 04:30:18PM -0700, Nick Crews wrote: > > On Fri, Mar 29, 2019 at 1:03 PM Rushikesh S Kadam > > wrote: > > > + ldr_xfer_ipc_frag = kzalloc(LOADER_SHIM_IPC_BUF_SIZE, GFP_KERNEL); > > > + if

Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-30 Thread Rushikesh S Kadam
Hi Nick I've few comments below about your suggestions, On Fri, Mar 29, 2019 at 04:30:18PM -0700, Nick Crews wrote: > On Fri, Mar 29, 2019 at 1:03 PM Rushikesh S Kadam > wrote: > > > > +/** > > + * ish_fw_xfer_ishtp() Loads ISH firmware using ishtp interface > > + * @client_data: Client

Re: [PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-29 Thread Nick Crews
On Fri, Mar 29, 2019 at 1:03 PM Rushikesh S Kadam wrote: > > This driver adds support for loading Intel Integrated > Sensor Hub (ISH) firmware from host file system to ISH > SRAM and start execution. > > At power-on, the ISH subsystem shall boot to an interim > Shim loader-firmware, which shall

[PATCH v3] HID: intel-ish-hid: ISH firmware loader client driver

2019-03-29 Thread Rushikesh S Kadam
This driver adds support for loading Intel Integrated Sensor Hub (ISH) firmware from host file system to ISH SRAM and start execution. At power-on, the ISH subsystem shall boot to an interim Shim loader-firmware, which shall expose an ISHTP loader device. The driver implements an ISHTP client