Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

2020-09-25 Thread Jiri Kosina
On Thu, 10 Sep 2020, Kamil Domański wrote: > Hi Jiri, > I'm not sure what you mean by "proper changelog that should go to the > commitlog". > Is the commit message "HID: logitech-hidpp: add support for Logitech G533 > headset" inadequate? That's a shortlog. But please provide also brief explanati

Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

2020-08-31 Thread Jiri Kosina
On Sat, 4 Jul 2020, Kamil Domański wrote: > Changelog: > v2: > - changed charging status parsing to account for invalid states > v3: > - rebased against Linux v5.7 > - changed variable naming in hidpp20_adc_map_status_voltage > to camel case > - corrected comment styling in hidpp_b

Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

2020-07-04 Thread Filipe Laíns
On Sat, 2020-07-04 at 02:47 +0200, Kamil Domański wrote: > Changelog: > v2: > - changed charging status parsing to account for invalid states > v3: > - rebased against Linux v5.7 > - changed variable naming in hidpp20_adc_map_status_voltage > to camel case > - corrected comment styl

[PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

2020-07-03 Thread Kamil Domański
Changelog: v2: - changed charging status parsing to account for invalid states v3: - rebased against Linux v5.7 - changed variable naming in hidpp20_adc_map_status_voltage to camel case - corrected comment styling in hidpp_battery_get_property - dropped usage of test_bit macro in

[PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset

2020-07-03 Thread Kamil Domański
Changelog: v2: - changed charging status parsing to account for invalid states v3: - rebased against Linux v5.7 - changed variable naming in hidpp20_adc_map_status_voltage to camel case - corrected comment styling in hidpp_battery_get_property - dropped usage of test_bit macro in