Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

2020-06-18 Thread Jason Gunthorpe
On Wed, Jun 17, 2020 at 10:08:03PM +0800, Jing Xiangfeng wrote: > The callers pass the pointer '' or 'private_data' to > srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req(). > 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that > sdev and req are always

Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

2020-06-18 Thread Bart Van Assche
On 2020-06-17 07:08, Jing Xiangfeng wrote: > The callers pass the pointer '' or 'private_data' to > srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req(). > 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that > sdev and req are always valid. So we remove

[PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv

2020-06-17 Thread Jing Xiangfeng
The callers pass the pointer '' or 'private_data' to srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req(). 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that sdev and req are always valid. So we remove unnecessary WARN_ON. Signed-off-by: Jing Xiangfeng