Re: [PATCH v3] Input: add bu21029 touch driver

2018-06-18 Thread Jonas Mark (BT-FIR/ENG1)
Hi kbuild test robot, > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on v4.17-rc4] > [also build test WARNING on next-20180615] > [cannot apply to input/next] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the syst

Re: [PATCH v3] Input: add bu21029 touch driver

2018-06-17 Thread kbuild test robot
Hi Zhu, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on v4.17-rc4] [also build test WARNING on next-20180615] [cannot apply to input/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://githu

AW: [PATCH v3] Input: add bu21029 touch driver

2018-05-17 Thread Jonas Mark (BT-FIR/ENG1)
Hello Dmitry, > > > > +static void bu21029_stop_chip(struct input_dev *dev) > > > > +{ > > > > + struct bu21029_ts_data *bu21029 = input_get_drvdata(dev); > > > > + > > > > + disable_irq(bu21029->client->irq); > > > > + del_timer_sync(&bu21029->timer); > > > > + > > > > + /

Re: [PATCH v3] Input: add bu21029 touch driver

2018-05-16 Thread Dmitry Torokhov
On Wed, May 16, 2018 at 01:24:24PM +, Jonas Mark (BT-FIR/ENG1) wrote: > Hello Andy, > > > > Add Rohm BU21029 resistive touch panel controller support with I2C > > > interface. > > > > > +#include > > > > This becomes redundant (see below). > > Removed. > > > > +#define STOP_DELAY_US 50L

AW: [PATCH v3] Input: add bu21029 touch driver

2018-05-16 Thread Jonas Mark (BT-FIR/ENG1)
Hello Andy, > > Add Rohm BU21029 resistive touch panel controller support with I2C > > interface. > > > +#include > > This becomes redundant (see below). Removed. > > +#define STOP_DELAY_US 50L > > +#define START_DELAY_MS 2L > > +#define BUF_LEN8L > > No need to use L for such small

Re: [PATCH v3] Input: add bu21029 touch driver

2018-05-13 Thread Andy Shevchenko
On Fri, May 11, 2018 at 5:22 PM, Mark Jonas wrote: > Add Rohm BU21029 resistive touch panel controller support with I2C > interface. > +#include This becomes redundant (see below). > +#define STOP_DELAY_US 50L > +#define START_DELAY_MS 2L > +#define BUF_LEN8L No need to use L for su

[PATCH v3] Input: add bu21029 touch driver

2018-05-11 Thread Mark Jonas
From: Zhu Yi Add Rohm BU21029 resistive touch panel controller support with I2C interface. Signed-off-by: Zhu Yi Signed-off-by: Mark Jonas Reviewed-by: Heiko Schocher Reviewed-by: Rob Herring --- Changes in v3: - reviewed by Rob Herring --- Changes in v2: - make ABS_PRESSURE proportionally