Re: [PATCH v3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability

2017-03-22 Thread Wanpeng Li
2017-03-23 2:20 GMT+08:00 Jim Mattson : > Is cpu_has_vmx_invvpid() sufficient? This indicates support for the > INVVPID instruction, but not necessarily any of the desired INVVPID > types. KVM's vpid_sync_context() assumes that at least one of > {VMX_VPID_EXTENT_SINGLE_CONTEXT, VMX_VPID_EXTENT_ALL_

Re: [PATCH v3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability

2017-03-22 Thread Jim Mattson
Is cpu_has_vmx_invvpid() sufficient? This indicates support for the INVVPID instruction, but not necessarily any of the desired INVVPID types. KVM's vpid_sync_context() assumes that at least one of {VMX_VPID_EXTENT_SINGLE_CONTEXT, VMX_VPID_EXTENT_ALL_CONTEXT} is supported. On Wed, Mar 22, 2017 at

Re: [PATCH v3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability

2017-03-22 Thread David Hildenbrand
On 22.03.2017 02:19, Wanpeng Li wrote: > From: Wanpeng Li > > This can be reproduced by running L2 on L1, and disable VPID on L0 if w/o > commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 crash as below: > > KVM: entry failed, hardware error 0x7 > EAX= EBX= ECX=00

[PATCH v3] KVM: VMX: Fix enable VPID even if INVVPID is not exposed in vmx capability

2017-03-21 Thread Wanpeng Li
From: Wanpeng Li This can be reproduced by running L2 on L1, and disable VPID on L0 if w/o commit "KVM: nVMX: Fix nested VPID vmx exec control", the L2 crash as below: KVM: entry failed, hardware error 0x7 EAX= EBX= ECX= EDX=000306c3 ESI= EDI= EBP=000